-
Notifications
You must be signed in to change notification settings - Fork 96
Introduce seekret #69
Conversation
@alain-hoang This would be a good place to have standup although it'll be a little like talking into the void. But raise any concerns, questions, comments, funny memes 😉 in here and we can triage them with other engineers intrested in helping out. 👍 |
👀 look at the tests failure here. @alain-hoang |
See #83 for more information on these failures |
And do we really need git-secrets? Nope.
This addresses downloading of the seekret rules via a curl request to a well known location for the rulesets.
* basic functional tests for git-seekrets
This makes sure that AWS keys are not mistaken for New Relic license keys.
This reverts commit e22aeb8.
Make sure AWS secrets start with AWS
# git secrets --add --allowed --global 'sha.*[A-Za-z0-9]{40}' || true | ||
# git secrets --add --allowed --global 'secure:.*' || true | ||
# TODO: Change to master for merge | ||
curl -s https://raw.githubusercontent.com/18F/laptop/seekret/seekrets-install | sh - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving a reminder here to change the path to point to master before merging.
Use files in `seekret-rules` to determine defaults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I was able to install it and running git seekret check -c 0
against the identity-idp
repo found no offenses, after Roger fixed the aws.rule regex.
Promote the branch names to master from seekret
How difficult would this be to extract from the laptop repository? We also would want to use this on potential Linux environments, and it'd be nice to make it reusable by others (and garner contributions from others) who aren't using our laptop configuration system. |
@konklone not very difficult at all. The main repository for To extract the installation from this repo, we would just need to move a few things:
|
Conversation moved to 18F/git-seekret#11 |
This PR introduces Git-Seekret
Setup of git-seekret per repo cases covered
Rules enabled
Screenshot of the after clone case
Gotchas:
To ensure reliable of installation of git-seekret there are some options that need to happen, either:
UX of it catching an error:
Before merge read #69 (comment) 👀
master
master