feat(curriculum): add test number enumeration (freeCodeCamp#55874)

1420663 · Aug 29, 2024 · 4a29f23 · 4a29f23
1 parent 786a49d
commit 4a29f23
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/client/src/templates/Challenges/components/test-suite.tsx b/client/src/templates/Challenges/components/test-suite.tsx
@@ -43,7 +43,7 @@ function TestSuite({ tests }: TestSuiteProps): JSX.Element {
             pass && !err ? t('icons.passed') : t('icons.failed');
           // Remove opening/closing <p> so screen reader will read both
           // status message and test text as one block.
-          text = text.replace(/^<p>|<\/p>$/g, '');
+          text = `${index + 1}. ${text.replace(/^<p>|<\/p>$/g, '')}`;
           return (
             <li
               className='test-result'

diff --git a/client/src/templates/Challenges/redux/execute-challenge-saga.js b/client/src/templates/Challenges/redux/execute-challenge-saga.js
@@ -232,6 +232,7 @@ function* executeTests(testRunner, tests, testTimeout = 5000) {
         newTest.stack = stack;
       }
 
+      newTest.message = newTest.message.replace(/<p>/, `<p>${i + 1}. `);
       yield put(updateConsole(newTest.message));
     } finally {
       testResults.push(newTest);

diff --git a/e2e/output.spec.ts b/e2e/output.spec.ts
@@ -13,7 +13,7 @@ const outputTexts = {
   > 1 | var
       |    ^`,
   empty: `// running tests
-  You should declare myName with the var keyword, ending with a semicolon
+  1. You should declare myName with the var keyword, ending with a semicolon
   // tests completed`,
   passed: `// running tests
 // tests completed`

diff --git a/e2e/test-suite.spec.ts b/e2e/test-suite.spec.ts
@@ -25,11 +25,15 @@ test.describe('Challenge Test Suite Component Tests', () => {
     await expect(page.getByTestId('test-result')).toHaveCount(3);
     await expect(page.getByText(translations.icons.initial)).toHaveCount(3);
     await expect(
-      page.getByText('You should not change code above the specified comment.')
+      page.getByText(
+        '1. You should not change code above the specified comment.'
+      )
     ).toBeVisible();
-    await expect(page.getByText('b should have a value of 7.')).toBeVisible();
     await expect(
-      page.getByText('a should be assigned to b with =.')
+      page.getByText('2. b should have a value of 7.')
+    ).toBeVisible();
+    await expect(
+      page.getByText('3. a should be assigned to b with =.')
     ).toBeVisible();
   });