feat: impl of zarr2 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the zarr v2 spec.
preyasshah
reviewed
Jun 11, 2024
preyasshah
reviewed
Jun 11, 2024
preyasshah
reviewed
Jun 11, 2024
| /// ``` | ||
| pub fn get_chunk_key(base_path: &str, array_meta: &ArrayMetadata, grid_position: &[u64]) -> String { | ||
| #[must_use] | ||
| pub fn get_chunk_key(key: &str, array_meta: &ArrayMetadata, grid_position: &[u64]) -> String { |
There was a problem hiding this comment.
explore if we can get rid of this and any dependent potential v3-only code that we have alt implementations in private repo
preyasshah
reviewed
Jun 11, 2024
remove filesystem and its deps remove integration tests (they all used filesystem)
This reverts commit a5f3fe4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the zarr v2 spec.