Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract all enclone only print code #415

Merged
merged 26 commits into from
Apr 23, 2024
Merged

refactor: extract all enclone only print code #415

merged 26 commits into from
Apr 23, 2024

Conversation

macklin-10x
Copy link
Contributor

No description provided.

@macklin-10x macklin-10x force-pushed the macklin/h5-loading-interface branch from 7e828f2 to e589288 Compare April 2, 2024 04:37
@macklin-10x macklin-10x force-pushed the macklin/extract-all-enclone-only-print-code branch from cb2c6e8 to 138e652 Compare April 2, 2024 06:48
@macklin-10x macklin-10x marked this pull request as ready for review April 2, 2024 07:35
Base automatically changed from macklin/h5-loading-interface to main April 2, 2024 19:29
@macklin-10x macklin-10x force-pushed the macklin/extract-all-enclone-only-print-code branch from 6d0a7c9 to 8bbdb40 Compare April 2, 2024 19:31
@macklin-10x
Extract all of the enclone-only part of print_clonotypes into a funct…
3e8ce33 
…ion.
@macklin-10x
Extract sort_exact_clonotypes as a function.
4ecb54a
@macklin-10x
Unfold the loop and clean up pass 1.
27fdb17
@macklin-10x
Clean up pass 2.
c1817c5
@macklin-10x
Explode the first pass loop into the top-level scope.
fa0463a
@macklin-10x
Explode pass 2 back out into top-level scope.
e70eec3
@macklin-10x
Clean up mutables and extract n_cells from the enclone-only data.
73dc695
@macklin-10x
Implement and inject processors.
0712b9b
@macklin-10x
impl on &mut rather than broken blanket impl
e2d8ba1
@macklin-10x
Move most of the remaining prep code into the enclone processor.
5d7f9cd
@macklin-10x
Move stop code into sole place it is used.
9340973
@macklin-10x
Move all the enclone-specific code into enclone proper.
4217238
@macklin-10x
Move a bunch of print code into enclone.
dbf378a
@macklin-10x
Move more print code.
1787b99
@macklin-10x
Move yet more printing code.
0b7a3d1
@macklin-10x
Move gene_scan.
f5b36f6
@macklin-10x
Move a whole ton more code into enclone.
027a70d
@macklin-10x
Scrape some more code out.
1206c28
@macklin-10x
Pull out one more module.
d46f74d
@macklin-10x
Add an assertion to make sure we never enter moved code.
916d5a7
@macklin-10x
Remove stats_pass1.
be5d09c
@macklin-10x macklin-10x force-pushed the macklin/extract-all-enclone-only-print-code branch from 8bbdb40 to 190578b Compare April 20, 2024 02:48
sreenathkrishnan
sreenathkrishnan approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@sreenathkrishnan sreenathkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 10k lines

@macklin-10x macklin-10x merged commit cbd15ef into main Apr 23, 2024
2 checks passed
@macklin-10x macklin-10x deleted the macklin/extract-all-enclone-only-print-code branch April 23, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreenathkrishnan sreenathkrishnan sreenathkrishnan approved these changes

@sjackman sjackman Awaiting requested review from sjackman

@shamoni shamoni Awaiting requested review from shamoni

@nmmsv10x nmmsv10x Awaiting requested review from nmmsv10x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macklin-10x @sreenathkrishnan