-
Notifications
You must be signed in to change notification settings - Fork 17
Passkey diagnostics guardrail #2042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c33b383 to
9a8efca
Compare
youngkidwarrior
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. A couple of NITs, but overall solid. Add those details about the risky vendors then go ahead and merge. Fix the NITs if you feel like it. Might save some headaches in the future
9a8efca to
a98436f
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
youngkidwarrior
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot. please update to use the expo devices package
|
Vercel Unique URL: https://sendapp-3820yat7l-0xsend.vercel.app |

This changeset verifies that the current environment can support basic functionality required to use the app properly and prevents users from creating an account on non-functional devices. In order to trigger the check, there is an env variable that can be set to always check, check high risk, or never. The high risk heuristic is based on devices that ship or previously did without robust built in passkey support, including chinese oems as well as the presence of google services on android and browser based check for passkey support on web. If the heuristic is triggered, or if the env var is set to always, it forces the user to immediately sign a dummy message with the new passkey to validate that it works before they can continue to the main app.
messaging/toasts.
destructuring.