Repository navigation
docs[cli]: state what mock match details actually cover - #202
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
docs/CLI.md told agents that --mock exposes the full MatchDetails shape (events, lineups, stats, formations) and recommended it for validating lineup pipelines. The bundled mocks in internal/data/mock_details.go only add events, statistics, venue, referee and attendance to the embedded Match, so home_lineup/home_starting/home_formation and their away counterparts are absent, and display_minute is populated on only some bundled events. Describe the actual mock coverage, and point lineup/formation validation at real matches in the TUI. Fixes 0xjuanma#201
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #201.
docs/CLI.mdtold agents that--mockexposes the fullMatchDetailsshape "(events, lineups, stats, formations)" and recommended mock IDs for validating a lineup jq pipeline. The bundled mocks do not carry those fields:internal/data/mock_details.goadds onlyEvents,Statistics,Venue,RefereeandAttendanceto the embeddedMatch; the same holds for the away side and for every bundled ID (2002-2005, 1001-1012).display_minuteis also only populated on some bundled events (2004/2005) while the documented event schema lists it unconditionally.The change is limited to
docs/CLI.md:Verified by re-reading both edited paragraphs and checking the claims against the built binary (
golazo match <id> --mockfor 2001-2005 and 1001-1012). No code or schema changes.