Support rendering new time signature mid-stave #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A time signature can be specified mid-stave in the form of *#/#* form. Ie. *3/4*, *7/8* etc. Limitations: - mid-stave time signature does not support common and cut-common time signatures - beam groupings are not changed by the new time signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A time signature can be specified mid-stave in the form of *#/#*.
Ie. *3/4*, *7/8* etc:
Limitations:
If you can provide some brief guidelines where to begin solving these limitations, please do so and I try to solve them.
Note: The tests fail, but this was not introduced by me, it is failing on the master branch too. I made an issue about this: #97