Skip to content

Cairo native feature flag#905

Merged
3alpha merged 2 commits intomainfrom
cairo-native-feature-flag
Feb 6, 2026
Merged

Cairo native feature flag#905
3alpha merged 2 commits intomainfrom
cairo-native-feature-flag

Conversation

@3alpha
Copy link
Collaborator

@3alpha 3alpha commented Feb 5, 2026

Resolves #826. Doesn't do anything for performance, but it is good to have it in here. Currently only available when compiling from source with a feature flag. Whether we will ship docker images with it is TBD.

Usage related changes

Development related changes

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

Summary by CodeRabbit

  • New Features

    • Native code execution is now available as an optional feature for improved performance.
  • Documentation

    • Added guidance on enabling native execution in build and deployment instructions, including runtime confirmation messages.

@3alpha
Copy link
Collaborator Author

3alpha commented Feb 5, 2026

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'auto_resolve_threads'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

This pull request introduces support for the cairo_native execution feature across the codebase. It adds a new cairo_native feature flag to four Cargo manifest files (starknet-devnet-core, starknet-devnet-server, starknet-devnet-types, and starknet-devnet), with dependencies on blockifier/cairo_native and starknet-types/cairo_native. Additional changes include updating the CI workflow to install LLVM 19 and extend cargo check with --all-features, bumping Starknet dependencies to 0.16.0-rc.3, adding documentation about the feature in the README and installation guide, and adding a conditional log message at startup when the feature is enabled.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description lacks detailed content in both required sections and provides minimal context for reviewers. Add detailed descriptions under 'Usage related changes' and 'Development related changes' sections explaining how users and developers are affected by the cairo_native feature implementation.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Cairo native feature flag' directly and specifically describes the main change—introducing a new cairo_native feature flag across multiple Cargo manifests and documentation.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cairo-native-feature-flag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@3alpha 3alpha merged commit 0057c18 into main Feb 6, 2026
3 checks passed
@3alpha 3alpha deleted the cairo-native-feature-flag branch February 6, 2026 20:54
@3alpha 3alpha added the enhancement New feature or request label Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Try out cairo-native

1 participant