[CDK-46] Add DAP CLI on Validium node #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
requested review from
vcastellm,
christophercampbell,
arnaubennassar,
begmaroman,
rachit77 and
Stefan-Ethernal
Stefan-Ethernal
approved these changes
Feb 7, 2024
goran-ethernal
force-pushed
the
CDK-46-add-dap-cli-on-validium-node
branch
from
668b6f9 to
9158242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new CLI command to
cdk-validium-nodefor setting up a new data availability protocol.The command is called
set-data-availability-protocol(alias isset-dap), and it has following flags:data-availability-address(da-addr) - address of the new data availability protocol.key-store-path(ksp) - the path of the key store file containing the private key of the account going to set new data availability protocol.password(pw) - the password do decrypt the key store file.cfg(c) - path tho the configuration file.network(net) - indicates which network configuration file should be loaded. For now onlycustomis supported.custom-network-file(net-file) - path to the custom network configuration file.The command loads the sender private key, creates an etherman instances and sends a transaction to the https://github.com/0xPolygonHermez/zkevm-contracts/blob/develop/contracts/v2/consensus/validium/PolygonValidiumEtrog.sol#L254 function.
This PR also adds an e2e test to check if the new CLI commands works as expected.