Skip to content

Feat/rig shared #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Feat/rig shared #436

wants to merge 2 commits into from

Conversation

mkranjac
Copy link
Contributor

@mkranjac mkranjac commented May 2, 2025

Relates to issue #434

Couple of notes:

  • Most of the crates have similar dependencies but with small variations on minor versions, using Workspace dependencies aims to simplify updates and removes redundant compilation. If you have any drawbacks with this approach I will revert it back to original.
  • Added fixtures for most commonly used mocks ( mostly for embeddings )
  • I named this crate rig-shared, at the moment it’s not ideal because it’s mostly for fixtures and common tools but if you have better alternative I will rename it
  • currently only AWS Bedrock crate is using this shared crate just for POC, if everything else is good I can refactor other crates.

@mkranjac mkranjac marked this pull request as draft May 2, 2025 12:56
@mkranjac
Copy link
Contributor Author

mkranjac commented May 2, 2025

@0xMochan @joshua-mo-143 please let me know if this is correct approach

@mkranjac mkranjac force-pushed the feat/rig-shared branch from 0be4e77 to 2d17c18 Compare May 7, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkranjac