Refactor asset handling and introduce SwapNoteStorage#2592
Open
PoulavBhowmick03 wants to merge 7 commits into0xMiden:nextfrom
Open
Refactor asset handling and introduce SwapNoteStorage#2592PoulavBhowmick03 wants to merge 7 commits into0xMiden:nextfrom
PoulavBhowmick03 wants to merge 7 commits into0xMiden:nextfrom
Conversation
Contributor
Author
|
I wrote it similar to |
Contributor
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good, thanks! I left a few comments.
bobbinth
approved these changes
Mar 16, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left one small comment inline.
| storage.extend_from_slice(&requested_asset.as_elements()); | ||
| storage.extend_from_slice(payback_recipient.digest().as_elements()); | ||
| let inputs = NoteStorage::new(storage)?; | ||
| let inputs = NoteStorage::from(swap_storage); |
Contributor
There was a problem hiding this comment.
nit: I'd rename the variable here from inputs to storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2515