ci: add changelog and PR changelog check #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CHANGELOG.md documenting v0.4.0 and upcoming v0.4.2 releases. Add CI workflow that requires CHANGELOG updates on PRs (skippable with "no changelog" label).
bobbinth
approved these changes
Jan 8, 2026
| @@ -0,0 +1,23 @@ | |||
| ## 0.4.2 (TBD) | |||
Contributor
There was a problem hiding this comment.
Since this is a breaking change, should we bump up to v0.5? On the other hand, it probably makes sense to keep in sync with P3 - and maybe we publish this one an yank v0.4.0 crates?
If we go with the second approach, we should make sure to release miden-crypto v0.21.0 very soon after this release so that we don't break next of miden-vm for too long.
Contributor
Author
There was a problem hiding this comment.
Second approach makes sense to me. /cc @Al-Kindi-0 @adr1anh
PR is 0xMiden/crypto#728 - with my recent edit, it's good to go right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CHANGELOG.md documenting v0.4.0 and upcoming v0.4.2 releases.
Add CI workflow that requires CHANGELOG updates on PRs (skippable with "no changelog" label).