Skip to content

fix: Return error if no tx inputs provided in submit_proven_transaction #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobbinth merged 2 commits into from
Mar 27, 2026
+4 −2
Merged

fix: Return error if no tx inputs provided in submit_proven_transaction #1852

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32879c8
Error out if no tx inputs
sergerad Mar 27, 2026
35f855e
Update comment
sergerad Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/rpc/src/server/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,10 +412,12 @@ impl api_server::Api for RpcService {
))
})?;

// If transaction inputs are provided, re-execute the transaction to validate it.
// Transaction inputs must be provided in order to allow for transaction re-execution via
// the Validator.
if request.transaction_inputs.is_some() {
// Re-execute the transaction via the Validator.
self.validator.clone().submit_proven_transaction(request.clone()).await?;
} else {
return Err(Status::invalid_argument("Transaction inputs must be provided"));
Comment on lines +419 to +420
Copy link
Copy Markdown
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi this can be written as

let request = request.transaction_inputs.ok_or(Err(...))?;

}

block_producer.clone().submit_proven_transaction(request).await
Expand Down
Loading