feat: move sync notes loop to the Store#1851
Merged
TomasArrachea merged 4 commits intotomasarrachea-sync-notes-reworkfrom Mar 27, 2026
Merged
feat: move sync notes loop to the Store#1851TomasArrachea merged 4 commits intotomasarrachea-sync-notes-reworkfrom
TomasArrachea merged 4 commits intotomasarrachea-sync-notes-reworkfrom
Conversation
Collaborator
Author
|
Merging this so it can be reviewed all together with #1843 since this simplifies the code a bit |
TomasArrachea
merged commit adbefa6
into
tomasarrachea-sync-notes-rework
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1843
Instead of batching the sync note responses at the RPC component, this PR batches them on the Store component. This minimizes the gRPC requests made internally by the node.