refactor(rpc): normalize NoteSyncRecord with NoteMetadataHeader#1837
Open
SantiagoPittella wants to merge 6 commits intonextfrom
Open
refactor(rpc): normalize NoteSyncRecord with NoteMetadataHeader#1837SantiagoPittella wants to merge 6 commits intonextfrom
SantiagoPittella wants to merge 6 commits intonextfrom
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-note-metadata-header-response
branch
from
facb2c5 to
d198527
Compare
bobbinth
approved these changes
Mar 26, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of small comments inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1720
NoteSyncRecordproto message to beNoteMetadataHeader+NoteInclusionInBlockProofinstead of carrying the fullNoteMetadata.NoteMetadataHeaderproto message containing the fixed-size metadata fields.NoteAttachmentKindproto enum mapping tomiden_protocol::note::NoteAttachmentKind.NoteMetadata(including attachment) should useGetNotesById.