feat: artifact support #122

lima-limon-inc · 2025-11-03T20:59:43Z

Closes: #121

This PR adds artifact support, both for executables and libraries. With this, midenup should first try to download an artifact if it exists. If it doesn't or the fetching fails, then it proceeds to install from source.

Implementation notes:

The Artifact struct holds a URI which is used to fetch the artifact, either from a URL (prefixed by https://) or from a file (prefixed by file://). Each artifact only holds a specific triplet (for more information, see LLVM's triplet implementation), which is displayed in the URI itself, for example:
- https://github.com/0xMiden/miden-client/releases/download/0.0/client-aarch64-apple-darwin: Holds the miden-client's binary for aarch64-apple-darwin
- https://github.com/0xMiden/miden-vm/releases/download/0.0/std.masp: Holds the Package for the std library. (Do note that masp packages are used by the MidenVM and so therefore these URIs do not have a platform dependent triplet).
The src/external.rs file holds functions that are imported into the install script by the include_str macro. These were added in a separate file to enhance readability.
As a final note, now if a component fails to get installed, midenup will simply skip said component if it's in release mode. In debug mode, it panics.

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

lima-limon-inc · 2025-11-06T15:11:19Z

Hi there @bitwalker. Status update: This PR is almost ready for review, I'm doing some final polishing.

Before merging this, I think it would be worthwhile to add an artifact field to at least one component, so that we can check that it works properly. So far, I've been testing this with a simple hello world binary.

Maybe we could try adding the debugger, since that's where the release github action currently resides. Is the next branch ready for merging? Did you have something else in mind?
Do let me know if I can help with anything!

lima-limon-inc · 2025-11-06T15:13:01Z

src/commands/install.rs

+    // bin/ directory which holds binaries.
+    let bin_dir = toolchain_dir.join("bin");
+    if !bin_dir.exists() {
+        std::fs::create_dir_all(&bin_dir).with_context(|| {
+            format!("failed to create toolchain directory: '{}'", bin_dir.display())
+        })?;
+    }
+
+    // lib/ directory which holds MASP libraries.
+    let lib_dir = toolchain_dir.join("lib");
+    if !lib_dir.exists() {
+        std::fs::create_dir_all(&lib_dir).with_context(|| {
+            format!("failed to create toolchain directory: '{}'", lib_dir.display())
+        })?;
+    }
+
+    // opt/ directory which holds symlinks to binaries in bin/.
+    // These are used in order to preserve a "midenup" compatible
+    // interface. This relies on the fact that clap uses argv[0] in order to
+    // display executable names names. These symlinks have the following format:
+    // `miden <component name>`
+    // Then, when `miden` is invoked, it uses these symlinks to execute the
+    // underlying binary.  With this setup, `clap` displays the name as: `miden
+    // <component name>` instead of just `binary_name` when displaying help
+    // messages.


opt/, bin/ and lib/ did not change in this PR. I simply added these lines and comments to elaborate on their functionality.

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

lima-limon-inc · 2025-11-06T20:49:40Z

src/commands/install.rs

 {%- else if dep.path %}, path = "{{ dep.path }}"
 {%- endif %} }
 {%- endfor %}
+curl = "{{ curl_version }}"


This will use the same version of CURL as the midenup itself. This is obtained in the build.rs file.

lima-limon-inc · 2025-11-07T12:57:56Z

manifest/channel-manifest.json

+          "artifacts": [
+              {
+                  "target": "zkvm-miden-unknown",
+                  "uri": "https://github.com/lima-limon-inc/fabriz.io/releases/download/0.0/std.masp"


These URLS are not intended to be merged and are only here to test this PR. They should be removed before merging.

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

lima-limon-inc · 2025-11-14T14:50:01Z

Sidenote: I'll give the implementation a rework. I'll replace the triplet to url table with a list of urls instead to simplify things.

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

bitwalker · 2025-12-31T22:26:17Z

@lima-limon-inc I finally got the the release workflow for miden-debug sorted with artifact (with attestation) support working, with the v0.4.4 release.

v0.4.4 can be used with the v0.19 toolchain, upcoming releases will work with v0.20+. In the meantime, hopefully that provides all that is needed to validate a real component works with this feature.

feat: pass $TARGET triple to crate at compile time

22cb532

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

lima-limon-inc self-assigned this Nov 3, 2025

lima-limon-inc added command:midenup An issue or task related to the `midenup` command check:install PRs only: runs workflows that perform additional end-to-end integration testing labels Nov 3, 2025

lima-limon-inc changed the base branch from main to fabrizioorsi/i113-remove-hardcoded-components November 3, 2025 20:59

lima-limon-inc force-pushed the fabrizioorsi/i121-artifact-support branch 4 times, most recently from 77a15c8 to 2fb1bef Compare November 6, 2025 14:47

lima-limon-inc commented Nov 6, 2025

View reviewed changes

lima-limon-inc force-pushed the fabrizioorsi/i121-artifact-support branch from 2fb1bef to f24bcb3 Compare November 6, 2025 15:21

lima-limon-inc added 12 commits November 6, 2025 12:37

feat: initial TargetTriple implementation

e0b66c1

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: add Display impl for TargetTriple

f2cbb16

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: implement artifact serialization

3cf9674

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: add Artifacts to Component

8e095e5

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: create lib and bin directories before executing the install script

85d1d75

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: download artifacts

610e10c

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: final touches when installing artifacts

734b715

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: add file// support for artifacts

53a8aab

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

refactor: move install_artifact to cargo script

889216c

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: obtain curl version from Cargo.toml instead of hardcoding it

3cd188e

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

refactor: make installation pipeline more linear

9c9212f

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: save downloaded file in .tmp, then rename it when finished

0a4ba74

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

lima-limon-inc force-pushed the fabrizioorsi/i121-artifact-support branch from f24bcb3 to 0a4ba74 Compare November 6, 2025 17:33

lima-limon-inc added 5 commits November 6, 2025 14:54

feat: fail in debug builds, continue in release mode

a3da0d7

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: remove test file:// artifact from VM

305f5e6

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: add artifact support in libraries

7727632

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: add std.masp as an example

08f3053

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: add miden VM Triplet

a309539

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

lima-limon-inc added 3 commits November 6, 2025 17:27

feat: update manifest with new Triplet

c18366e

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

feat: add miden to the list of wellknown targets

6b7c1e8

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

chore: reword comments

c82f722

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

lima-limon-inc marked this pull request as ready for review November 6, 2025 20:47

lima-limon-inc force-pushed the fabrizioorsi/i121-artifact-support branch from d184473 to c82f722 Compare November 6, 2025 20:47

lima-limon-inc commented Nov 6, 2025

View reviewed changes

lima-limon-inc requested a review from bitwalker November 6, 2025 20:53

lima-limon-inc commented Nov 7, 2025

View reviewed changes

Base automatically changed from fabrizioorsi/i113-remove-hardcoded-components to main November 10, 2025 12:46

lima-limon-inc added 2 commits November 10, 2025 12:58

Merge branch 'main' into fabrizioorsi/i121-artifact-support

d8395a7

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

Merge branch 'main' into fabrizioorsi/i121-artifact-support

d0d2f32

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

lima-limon-inc force-pushed the fabrizioorsi/i121-artifact-support branch from 30d37dd to d0d2f32 Compare November 13, 2025 17:52

lima-limon-inc added 2 commits November 13, 2025 15:15

Merge branch 'main' into fabrizioorsi/i121-artifact-support

0b42d98

Merge branch 'main' into fabrizioorsi/i121-artifact-support

eb5d145

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

lima-limon-inc marked this pull request as draft November 14, 2025 14:50

lima-limon-inc added 9 commits November 14, 2025 16:56

WIP

ab2b6de

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

refactor: remove Artifact HashMap in favor of lists

7fec7b8

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

refactor: take MidenVM artifacts into account

e7a32f0

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

refactor: remove target from artifact, obtain it from the link itself

f32fcdc

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

refactor: contains now returns the Option<String> instead of bool

31aa2a2

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

refactor: rename Artifact::contains -> Artifact::get_uri_for

3d138da

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

nit: make lint

54d3b42

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

nit: remove pub indicator from Artifact

a2d9adb

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

docs: expand Artifact documentation

40842f4

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

lima-limon-inc marked this pull request as ready for review November 25, 2025 15:52

nit: remove example artifact uris

d4acf30

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: artifact support #122

feat: artifact support #122

Uh oh!

lima-limon-inc commented Nov 3, 2025 •

edited

Loading

Uh oh!

lima-limon-inc commented Nov 6, 2025

Uh oh!

lima-limon-inc Nov 6, 2025 •

edited

Loading

Uh oh!

lima-limon-inc Nov 6, 2025 •

edited

Loading

Uh oh!

lima-limon-inc Nov 7, 2025

Uh oh!

lima-limon-inc commented Nov 14, 2025

Uh oh!

bitwalker commented Dec 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: artifact support #122

Are you sure you want to change the base?

feat: artifact support #122

Uh oh!

Conversation

lima-limon-inc commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lima-limon-inc commented Nov 6, 2025

Uh oh!

lima-limon-inc Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lima-limon-inc Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lima-limon-inc Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

lima-limon-inc commented Nov 14, 2025

Uh oh!

bitwalker commented Dec 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lima-limon-inc commented Nov 3, 2025 •

edited

Loading

lima-limon-inc Nov 6, 2025 •

edited

Loading

lima-limon-inc Nov 6, 2025 •

edited

Loading