chore: update miden-crypto (with unified Felt type)#2649
Conversation
975be34 to
3ced18f
Compare
|
Since I already merged v0.21 VM into |
I created branch |
68caf29 to
6534414
Compare
6534414 to
85ee767
Compare
Oh, actually I was targeting Should I remove the |
9913bf9 to
8c7d0fe
Compare
8c7d0fe to
757e85b
Compare
|
The snapshots in the trace generation tests changed. I updated them in the separate commit - e28bc37. |
|
Rebased and ready. |
I'm not sure why they have changed thought. The exact change is hard to pinpoint since the diff is hard to read (some changes in the 700 KB one liner). |
There was a problem hiding this comment.
Upon further investigation, changes in the debug output of the AdviceProvider (part of the ExecutionTrace printed here) are what's causing the diff here. Specifically, Word ordering was changed, which means that Words in the MerkleStore are debug-printed in a different order.
This PR tests the updated
miden-cryptowith the unifiedFelttype.See 0xMiden/crypto#771 for more details on why we want this.
The
miden-cryptoPR is 0xMiden/crypto#819. It swaps theGoldilocks as Feltre-export to theFelt(Goldilocks)wrapper.