Skip to content

chore: update miden-crypto (with unified Felt type)#2649

Merged
bobbinth merged 6 commits intomainfrom
greenhat-unified-felt
Feb 24, 2026
Merged

chore: update miden-crypto (with unified Felt type)#2649
bobbinth merged 6 commits intomainfrom
greenhat-unified-felt

Conversation

@greenhat
Copy link
Copy Markdown
Collaborator

@greenhat greenhat commented Feb 6, 2026

This PR tests the updated miden-crypto with the unified Felt type.
See 0xMiden/crypto#771 for more details on why we want this.
The miden-crypto PR is 0xMiden/crypto#819. It swaps the Goldilocks as Felt re-export to the Felt(Goldilocks) wrapper.

@bobbinth
Copy link
Copy Markdown
Contributor

Since I already merged v0.21 VM into main, we'll need to create a branch from the v0.20.6tag and target this PR for that branch (we could call the branchv0.21.7`).

@greenhat
Copy link
Copy Markdown
Collaborator Author

Since I already merged v0.21 VM into main, we'll need to create a branch from the v0.20.6tag and target this PR for that branch (we could call the branchv0.21.7`).

I created branch v0.20.7 and will rebase this branch onto it.

@greenhat greenhat force-pushed the greenhat-unified-felt branch from 68caf29 to 6534414 Compare February 18, 2026 12:53
@greenhat greenhat changed the base branch from next to v0.20.7 February 18, 2026 12:54
@greenhat greenhat force-pushed the greenhat-unified-felt branch from 6534414 to 85ee767 Compare February 18, 2026 13:05
@greenhat greenhat changed the base branch from v0.20.7 to main February 18, 2026 13:05
@greenhat
Copy link
Copy Markdown
Collaborator Author

Since I already merged v0.21 VM into main, we'll need to create a branch from the v0.20.6tag and target this PR for that branch (we could call the branchv0.21.7`).

I created branch v0.20.7 and will rebase this branch onto it.

Oh, actually I was targeting main with the v0.21 release and NOT v0.20.x so I'm staying targeting main.

Should I remove the v0.20.7 branch, or do you need it anyway?

@greenhat greenhat force-pushed the greenhat-unified-felt branch 6 times, most recently from 9913bf9 to 8c7d0fe Compare February 24, 2026 10:04
@greenhat greenhat force-pushed the greenhat-unified-felt branch from 8c7d0fe to 757e85b Compare February 24, 2026 11:13
@greenhat
Copy link
Copy Markdown
Collaborator Author

The snapshots in the trace generation tests changed. I updated them in the separate commit - e28bc37.

@greenhat greenhat marked this pull request as ready for review February 24, 2026 12:14
@greenhat greenhat requested a review from bobbinth February 24, 2026 12:14
@greenhat
Copy link
Copy Markdown
Collaborator Author

Rebased and ready.

@greenhat
Copy link
Copy Markdown
Collaborator Author

The snapshots in the trace generation tests changed. I updated them in the separate commit - e28bc37.

I'm not sure why they have changed thought. The exact change is hard to pinpoint since the diff is hard to read (some changes in the 700 KB one liner).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon further investigation, changes in the debug output of the AdviceProvider (part of the ExecutionTrace printed here) are what's causing the diff here. Specifically, Word ordering was changed, which means that Words in the MerkleStore are debug-printed in a different order.

Copy link
Copy Markdown
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit 4780427 into main Feb 24, 2026
16 checks passed
@bobbinth bobbinth deleted the greenhat-unified-felt branch February 24, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants