refactor: Make StackInputs and StackOutputs Copy #2581
Merged
+27
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
requested changes
Jan 14, 2026
Contributor
huitseeker
left a comment
huitseeker
left a comment
There was a problem hiding this comment.
Please add a line in the CHANGELOG.md
miden-vm/benches/build_trace.rs
Outdated
| .with_library(&CoreLibrary::default()) | ||
| .unwrap(); | ||
| let stack_inputs = stack_inputs.clone(); | ||
| let stack_inputs = stack_inputs; |
Contributor
There was a problem hiding this comment.
this line is now a no-op since StackInputs is Copy. you could just delete it entirely.
Contributor
Contributor
|
There also appear to be some merge conflicts. @avorylli - would you be able to resolve them? |
Contributor
Author
huitseeker
force-pushed
the
refactor/make-stack-inputs-outputs-copy
branch
2 times, most recently
from
a37aedc to
edaa754
Compare
huitseeker
force-pushed
the
refactor/make-stack-inputs-outputs-copy
branch
from
edaa754 to
ad18cf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Make
StackInputsandStackOutputsimplementCopytrait since they are wrappers around[Felt; 16]which isCopy.Changes:
Copyderive toStackInputsandStackOutputsstructs.clone()calls in 25 locations across the codebaseCloses #2487
Reopen #2503