Skip to content

Conversation

@Himess
Copy link
Contributor

@Himess Himess commented Jan 9, 2026

Closes #2532

@Himess Himess marked this pull request as draft January 9, 2026 01:16
@Himess Himess force-pushed the issue-2532-from-vec-for-indexvec branch 2 times, most recently from 7106042 to aa9b8b2 Compare January 9, 2026 01:27
@Himess Himess marked this pull request as ready for review January 9, 2026 01:27
@Himess Himess force-pushed the issue-2532-from-vec-for-indexvec branch from aa9b8b2 to 04c0895 Compare January 9, 2026 01:29
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry, this issue seems to have been closed in #2470! This added a TryFrom<Vec<T>> for IndexedVec<I, T> which is actually more appropriate considering the failure potential.

However, the challenge, now is to use it in the context in which this originally appeared, i.e. this should be used here:

let mut node_indptr_for_op_idx = IndexVec::new();
for _ in 0..=num_nodes {
let _ = node_indptr_for_op_idx.push(0);
}

@Himess
Copy link
Contributor Author

Himess commented Jan 9, 2026

Not a problem at all @huitseeker, I've updated the PR as you suggested

@huitseeker huitseeker changed the title Add From<Vec<T>> impl for IndexVec Use TryFrom<Vec<T>> impl for IndexVec Jan 9, 2026
@huitseeker huitseeker merged commit d7db762 into 0xMiden:next Jan 9, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add From<Vec<T>> for IndexVec<I, T>

2 participants