Only execute trace decorators when tracing is enabled #2539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafer
force-pushed
the
plafer-2479-processor-debug-mode
branch
from
8473e1f to
0843cad
Compare
plafer
force-pushed
the
plafer-2535-cycle-count-limit
branch
from
cbdabec to
15bd24a
Compare
plafer
force-pushed
the
plafer-2479-processor-debug-mode
branch
from
0843cad to
bd5b010
Compare
plafer
force-pushed
the
plafer-2535-cycle-count-limit
branch
from
15bd24a to
bcf0479
Compare
plafer
force-pushed
the
plafer-2535-cycle-count-limit
branch
from
bcf0479 to
2bf0d59
Compare
plafer
force-pushed
the
plafer-2479-processor-debug-mode
branch
from
bd5b010 to
2432b21
Compare
plafer
force-pushed
the
plafer-2535-cycle-count-limit
branch
from
2bf0d59 to
7685950
Compare
plafer
force-pushed
the
plafer-2479-processor-debug-mode
branch
from
2432b21 to
5fc0465
Compare
plafer
force-pushed
the
plafer-2535-cycle-count-limit
branch
from
7685950 to
231ef56
Compare
plafer
force-pushed
the
plafer-2479-processor-debug-mode
branch
from
5fc0465 to
5f0c0f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2479
tracedecorators are now only executed whenExecutionOptions::enable_tracing()is set. The debug mode part was already fixed with #2534. As a result, all tests mentioned in #2479 that were disabled were re-enabled.