refactor: Make StackInputs and StackOutputs Copy

core/src/stack/inputs.rs

@@ -16,7 +16,7 @@ use crate::{
 ///
 /// The values in the struct are stored in the "stack order" - i.e., the last input is at the top
 /// of the stack (in position 0).
-#[derive(Clone, Debug, Default)]
+#[derive(Clone, Copy, Debug, Default)]
 pub struct StackInputs {
     elements: [Felt; MIN_STACK_DEPTH],
 }

core/src/stack/outputs.rs

@@ -19,7 +19,7 @@ use crate::utils::{ByteReader, Deserializable, DeserializationError, range};
 /// `stack` is expected to be ordered as if the elements were popped off the stack one by one.
 /// Thus, the value at the top of the stack is expected to be in the first position, and the order
 /// of the rest of the output elements will also match the order on the stack.
-#[derive(Debug, Clone, Default, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, Default, PartialEq, Eq)]
 pub struct StackOutputs {
     elements: [Felt; MIN_STACK_DEPTH],
 }

crates/lib/core/tests/stark/mod.rs

@@ -88,7 +88,7 @@ pub fn generate_recursive_verifier_data(
         ProvingOptions::new(27, 8, 0, FieldExtension::Quadratic, 4, 127, HashFunction::Rpo256);
 
     let (stack_outputs, proof) =
-        prove(&program, stack_inputs.clone(), advice_inputs, &mut host, options).unwrap();
+        prove(&program, stack_inputs, advice_inputs, &mut host, options).unwrap();
 
     let program_info = ProgramInfo::from(program);
 

crates/test-utils/src/lib.rs

@@ -276,7 +276,7 @@ impl Test {
         let mut host = host.with_source_manager(self.source_manager.clone());
 
         // execute the test
-        let stack_inputs: Vec<Felt> = self.stack_inputs.clone().into_iter().rev().collect();
+        let stack_inputs: Vec<Felt> = self.stack_inputs.into_iter().rev().collect();
         let processor = if self.in_debug_mode {
             FastProcessor::new_debug(&stack_inputs, self.advice_inputs.clone())
         } else {
@@ -385,7 +385,7 @@ impl Test {
         let mut host = host.with_source_manager(self.source_manager.clone());
 
         let fast_stack_result = {
-            let stack_inputs: Vec<Felt> = self.stack_inputs.clone().into_iter().rev().collect();
+            let stack_inputs: Vec<Felt> = self.stack_inputs.into_iter().rev().collect();
             let advice_inputs: AdviceInputs = self.advice_inputs.clone();
             let fast_processor =
                 FastProcessor::new_with_advice_inputs(&stack_inputs, advice_inputs);
@@ -417,7 +417,7 @@ impl Test {
         let mut host = host.with_source_manager(self.source_manager.clone());
 
         let processor = FastProcessor::new_debug(
-            &self.stack_inputs.clone().into_iter().rev().collect::<Vec<Felt>>(),
+            &self.stack_inputs.into_iter().rev().collect::<Vec<Felt>>(),
             self.advice_inputs.clone(),
         );
 
@@ -438,7 +438,7 @@ impl Test {
             .with_debug_handler(debug_handler);
 
         let processor = FastProcessor::new_debug(
-            &self.stack_inputs.clone().into_iter().rev().collect::<Vec<Felt>>(),
+            &self.stack_inputs.into_iter().rev().collect::<Vec<Felt>>(),
             self.advice_inputs.clone(),
         );
 
@@ -466,7 +466,7 @@ impl Test {
         let stack_inputs = StackInputs::try_from_ints(pub_inputs).unwrap();
         let (mut stack_outputs, proof) = miden_prover::prove_sync(
             &program,
-            stack_inputs.clone(),
+            stack_inputs,
             self.advice_inputs.clone(),
             &mut host,
             ProvingOptions::default(),
@@ -573,14 +573,14 @@ impl Test {
         let mut host = host.with_source_manager(self.source_manager.clone());
 
         let fast_result_by_step = {
-            let stack_inputs: Vec<Felt> = self.stack_inputs.clone().into_iter().rev().collect();
+            let stack_inputs: Vec<Felt> = self.stack_inputs.into_iter().rev().collect();
             let advice_inputs: AdviceInputs = self.advice_inputs.clone();
             let fast_process = FastProcessor::new_with_advice_inputs(&stack_inputs, advice_inputs);
             fast_process.execute_by_step_sync(&program, &mut host)
         };
 
         compare_results(
-            fast_result.as_ref().map(|(output, _)| output.stack.clone()),
+            fast_result.as_ref().map(|(output, _)| output.stack),
             &fast_result_by_step,
             "fast processor",
             "fast processor by step",