Skip to content

Conversation

@letmehateu
Copy link

@letmehateu letmehateu commented Dec 20, 2025

Describe your changes

  • TraceFragment::len() method: Added check for empty data before accessing self.data[0]
  • The method now safely returns 0 if the fragment contains no columns
  • Updated documentation to match the new behavior

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Commits are signed.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.
  • Updated `CHANGELOG.md'

@github-actions
Copy link

Automated check (CONTRIBUTING.md)

Findings:

  • Link an issue in the PR body (e.g., "Fixes Implement SHA256 in Miden Assembly #123").
  • Add a short Rationale explaining why the change is needed.
  • Change appears to be a trivial code-only edit without tests; may be batched internally.

Recommendations:

  • Consider adding a Test plan or clear review steps.

Next steps:

  • Link a relevant issue (e.g., "Fixes Implement SHA256 in Miden Assembly #123") and ensure it is assigned to you.
  • See CONTRIBUTING.md for expectations.
  • If this is a false positive, comment: /quality-review.

@bobbinth
Copy link
Contributor

bobbinth commented Jan 4, 2026

Thank you - but we do not accept PRs w/o associated issues.

@bobbinth bobbinth closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants