chore: miden base update followups

[SantiagoPittella]

In this PR I:

• Update miden-base version to v0.13.1.
• Use NetworkAccountTargetError from miden-base for attachment errors (chore: update with latest miden-base #1526 (comment) & chore: make NetworkAccountTargetError public miden-base#2319 ).
• Remove references to network account prefixes (chore: update with latest miden-base #1526 (comment)).
• Create the NetworkNoteType for database storage and remove is_single_target_network_note.

[bobbinth]

Looks good! Thank you! I left a couple of comments inline - but nothing that's blocking this PR.

I do think we potentially have a bigger issue though that we should address in a follow-up PR:

It seems like we are still relying on note tag to find notes for a network account. Technically, this shouldn't work because network notes shouldn't use tags to encode target accounts (cc @PhilippGackstatter to confirm). Instead, they should be using note attachment data which contains full ID of the target account.

This has a couple of implications:

• First, select_unconsumed_network_notes_by_tag() should really be select_unconsumed_network_notes_for_account() and should take account_id as a parameter instead of the tag.
• Second, in addition (or maybe instead of) network_note_type, we probably want to have something like target_account_id field that is populated only for single-target network notes. Then, the query would be filtering against this ID rather than the tag.

[bobbinth]

This may be a bigger refactoring, and so, probably not for this PR - but we should be using account ID here instead of network_account_prefix. Do we have an issue to change this already? If not, let's create one.

[Mirko-von-Leipzig]

We have #1549 which covers this

[PhilippGackstatter]

It seems like we are still relying on note tag to find notes for a network account. Technically, this shouldn't work because network notes shouldn't use tags to encode target accounts (cc @PhilippGackstatter to confirm). Instead, they should be using note attachment data which contains full ID of the target account.

Yes, we should not be relying on the note tag at all for network notes anymore and should use the NetworkAccountTarget attachment instead.

[Mirko-von-Leipzig]

It seems like we are still relying on note tag to find notes for a network account. Technically, this shouldn't work because network notes shouldn't use tags to encode target accounts (cc @PhilippGackstatter to confirm). Instead, they should be using note attachment data which contains full ID of the target account.

Yes, we should not be relying on the note tag at all for network notes anymore and should use the NetworkAccountTarget attachment instead.

As in, this will still work temporarily, or this won't work at all and must be fixed before deploying to testnet?

[PhilippGackstatter]

As in, this will still work temporarily, or this won't work at all and must be fixed before deploying to testnet?

Must be fixed before testnet. Relying on the note tag does not work anymore at all.

[drahnr]

@SantiagoPittella I accidentally pushed to this/your branch (one additional commit), and force pushed back to your original state. Nothing should have changed 🤞