feat(validator): FPI support in data store

CHANGELOG.md

@@ -22,6 +22,7 @@
 - Added `GetLimits` endpoint to the RPC server ([#1410](https://github.com/0xMiden/miden-node/pull/1410)).
 - Added gRPC-Web probe support to the `miden-network-monitor` binary ([#1484](https://github.com/0xMiden/miden-node/pull/1484)).
 - Add DB schema change check ([#1268](https://github.com/0xMiden/miden-node/pull/1485)).
+- Add foreign account support to validator ([#1493](https://github.com/0xMiden/miden-node/pull/1493)).
 - Improve DB query performance for account queries ([#1496](https://github.com/0xMiden/miden-node/pull/1496).
 - Limit number of storage map keys in `GetAccount` requests ([#1517](https://github.com/0xMiden/miden-node/pull/1517)).
 - The network monitor now marks the chain as unhealthy if it fails to create new blocks ([#1512](https://github.com/0xMiden/miden-node/pull/1512)).

crates/validator/src/tx_validation/data_store.rs

@@ -53,7 +53,11 @@ impl DataStore for TransactionInputsDataStore {
         foreign_account_id: AccountId,
         _ref_block: BlockNumber,
     ) -> impl FutureMaybeSend<Result<AccountInputs, DataStoreError>> {
-        async move { Err(DataStoreError::AccountNotFound(foreign_account_id)) }
+        async move {
+            self.tx_inputs.read_foreign_account_inputs(foreign_account_id).map_err(|err| {
+                DataStoreError::other_with_source("failed to read foreign account inputs", err)
+            })
+        }
     }
 
     fn get_vault_asset_witnesses(
@@ -63,58 +67,53 @@ impl DataStore for TransactionInputsDataStore {
         vault_keys: BTreeSet<AssetVaultKey>,
     ) -> impl FutureMaybeSend<Result<Vec<AssetWitness>, DataStoreError>> {
         async move {
-            if self.tx_inputs.account().id() != account_id {
-                return Err(DataStoreError::AccountNotFound(account_id));
-            }
-
-            if self.tx_inputs.account().vault().root() != vault_root {
-                return Err(DataStoreError::Other {
-                    error_msg: "vault root mismatch".into(),
-                    source: None,
-                });
+            if self.tx_inputs.account().id() == account_id {
+                // Get asset witnessess from native account.
+                Result::<Vec<_>, _>::from_iter(vault_keys.into_iter().map(|vault_key| {
+                    match self.tx_inputs.account().vault().open(vault_key) {
+                        Ok(vault_proof) => AssetWitness::new(vault_proof.into()).map_err(|err| {
+                            DataStoreError::other_with_source(
+                                "failed to open vault asset tree",
+                                err,
+                            )
+                        }),
+                        Err(err) => {
+                            Err(DataStoreError::other_with_source("failed to open vault", err))
+                        },
+                    }
+                }))
+            } else {
+                // Get asset witnessess from foreign account.
+                self.tx_inputs
+                    .read_vault_asset_witnesses(vault_root, vault_keys)
+                    .map_err(|err| {
+                        DataStoreError::other_with_source(
+                            "failed to read vault asset witnesses",
+                            err,
+                        )
+                    })
             }
-
-            Result::<Vec<_>, _>::from_iter(vault_keys.into_iter().map(|vault_key| {
-                match self.tx_inputs.account().vault().open(vault_key) {
-                    Ok(vault_proof) => {
-                        AssetWitness::new(vault_proof.into()).map_err(|err| DataStoreError::Other {
-                            error_msg: "failed to open vault asset tree".into(),
-                            source: Some(err.into()),
-                        })
-                    },
-                    Err(err) => Err(DataStoreError::Other {
-                        error_msg: "failed to open vault".into(),
-                        source: Some(err.into()),
-                    }),
-                }
-            }))
         }
     }
 
     fn get_storage_map_witness(
         &self,
-        account_id: AccountId,
+        _account_id: AccountId,
         _map_root: Word,
         _map_key: Word,
     ) -> impl FutureMaybeSend<Result<StorageMapWitness, DataStoreError>> {
         async move {
-            if self.tx_inputs.account().id() != account_id {
-                return Err(DataStoreError::AccountNotFound(account_id));
-            }
-
-            // For partial accounts, storage map witness is not available.
-            Err(DataStoreError::Other {
-                error_msg: "storage map witness not available with partial account state".into(),
-                source: None,
-            })
+            unimplemented!(
+                "get_storage_map_witness is not used during re-execution of transactions"
+            )
         }
     }
 
     fn get_note_script(
         &self,
         _script_root: Word,
     ) -> impl FutureMaybeSend<Result<Option<NoteScript>, DataStoreError>> {
-        async move { Ok(None) }
+        async move { unimplemented!("get_note_script is not used during re-execution of transactions") }
     }
 }