refactor [1/4]: change accounts db schema #1481
Open
+2,239
−505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
changed the title
bobbinth
reviewed
Dec 30, 2025
bobbinth
reviewed
Dec 30, 2025
drahnr
changed the title
bobbinth
reviewed
Jan 6, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I reviewed most non-test code and left some small comments inline.
Overall, I think this structure works for now, but we'll probably need to re-think this shortly after the refactoring is merged as in many places the interactions with the database are likely to be prohibitively expensive.
bobbinth
approved these changes
Jan 7, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I reviewed all non-test code and left one comment for the future inline.
Contributor
There was a problem hiding this comment.
Not for this PR: this file is pretty large and difficult to navigate. I think we should break it up into a few smaller files which contain logically grouped functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation / carve out from #1394 since the feedback caused additional linecount -
nosome minor functional changes were made!A large chunk of the linecount are testcases
Core changes
schema.rs- move storage map into separate table, avoid storing full serialized account toaccountstable, move vault data to separate table (breaking)models/conv.rs-StorageSlotType- change DB representation (breaking)queries/at_block.rs- add new*_at_blockqueriesfn validate_block_exists