feat(node): configure ntx script cache size via clap #1454
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergerad
reviewed
Jan 4, 2026
| bp_checkpoint: Arc<Barrier>, | ||
| script_cache_size: NonZeroUsize, | ||
| ) -> Self { | ||
| let script_cache = LruCache::new(script_cache_size); |
Collaborator
There was a problem hiding this comment.
I think we should just update new() and not have with_script_cache_size().
Author
There was a problem hiding this comment.
I think we should just update
new()and not havewith_script_cache_size().
updated
sergerad
reviewed
Jan 6, 2026
| const ENV_MAX_TXS_PER_BATCH: &str = "MIDEN_MAX_TXS_PER_BATCH"; | ||
| const ENV_MAX_BATCHES_PER_BLOCK: &str = "MIDEN_MAX_BATCHES_PER_BLOCK"; | ||
| const ENV_MEMPOOL_TX_CAPACITY: &str = "MIDEN_NODE_MEMPOOL_TX_CAPACITY"; | ||
| const ENV_NTX_SCRIPT_CACHE_SIZE: &str = "MIDEN_NTX_DATA_STORE_SCRIPT_CACHE_SIZE"; |
Collaborator
There was a problem hiding this comment.
Please add this to bin/node/.env like the other env vars.
sergerad
reviewed
Jan 6, 2026
| const COMPONENT: &str = "miden-ntx-builder"; | ||
|
|
||
| pub const DEFAULT_SCRIPT_CACHE_SIZE: NonZeroUsize = | ||
| NetworkTransactionBuilder::DEFAULT_SCRIPT_CACHE_SIZE; |
Collaborator
There was a problem hiding this comment.
We don't need this do we?
sergerad
reviewed
Jan 6, 2026
| /// Each cached script contains the deserialized `NoteScript` object, so the actual memory usage | ||
| /// depends on the complexity of the scripts being cached. | ||
| const DEFAULT_SCRIPT_CACHE_SIZE: NonZeroUsize = NonZeroUsize::new(1000).unwrap(); | ||
| pub const DEFAULT_SCRIPT_CACHE_SIZE: NonZeroUsize = NonZeroUsize::new(1000).unwrap(); |
Collaborator
There was a problem hiding this comment.
This doesn't need to be pub does it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopen #1340
Fixes #1335