Skip to content

chore: merge main into next #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igamigo merged 25 commits into from
Jan 23, 2026
Merged

chore: merge main into next #212

igamigo merged 25 commits into from
Jan 23, 2026

Conversation

@Keinberger
Copy link
Collaborator

@Keinberger Keinberger commented Jan 19, 2026

This PR merges the changes from the latest PR #196 into next.

This PR also changes the CHANGELOG.md to include the changes of #196 in v13 instead of a patch release on v12.

Keinberger and others added 24 commits December 16, 2025 13:21
@Keinberger
feat: implement mint command
0e614ba
@Keinberger
chore: update changelog
f5ce756
@Keinberger
feat: implement new miden-faucet-operator binary
c72de74 
feat: rename existing miden-faucet binary to miden-faucet-client

docs: update docs to include information about new miden-faucet-operator binary

chore: move tests of miden-faucet-operator binary into dedicated folder

docs(README): update README for binary separation

chore: update changelog
@Keinberger
chore(Makefile): update Makefile to include miden-faucet-operator bin…
ede1df1 
…ary installation
@Keinberger
docs: update README to include correct client start command
06f1dd9 
docs: update instructions to include correct client start command and mint command usage
@Keinberger
feat: rename faucet to faucet-operator and faucet-operator to faucet-…
b26a008 
…client (reverse naming)
@Keinberger
chore(CHANGELOG): amend statement
5324f7c 
fix(Makefile): install faucet instructions target correct binary

docs(README): added explainer for binary split

chore: removed redundant readme key in bin/faucet-client/Cargo.toml

chore: amend description satement in bin/faucet-operator/Cargo.toml
@Keinberger
chore: rename miden-faucet.service file
8b0a2c4
@Keinberger
fix(docs): correct naming for miden-faucet binaries
735310e
@Keinberger
docs: use correct api bind flag
9d81d0d 
docs: Clarify mint command technical accuracy
@Keinberger
feat: implement common response types across operator and client bina…
c04b641 
…ries

feat: implement backwards compatibility for legacy "miden-faucet" CLI command
@Keinberger
docs: add README for miden-faucet-client binary
799ce95
@Keinberger
chore: linting
6213ac8
@Keinberger
fix: prevent tests from being run on miden-faucet binary alias
f5029ac
@Keinberger
chore: export raw request parameters from miden-faucet-operator
94e7328
@Keinberger
chore: implement native miden_pow_rate_limiter package in faucet-client
4a8c51c
@Keinberger
chore(faucet-client): rename account flag to target, quantity to amount
c7352b9 
chore: amend character size of separators

docs(client/README): amend mint command explanation to be more technically accurate

chore(CHANGELOG): mark binary separation as breaking
@Keinberger
chore(action.yml): amend action workflow according to binary separation
49e14b3
@Keinberger
chore(publish-debian.yml): amend workflow for binary separation
04487c5
@Keinberger
chore(faucet): revert binary rename from miden-faucet-operator to mid…
4fee953 
…en-faucet
@Keinberger @mmagician
Update CHANGELOG.md
3874b6e 
Co-authored-by: Marti <[email protected]>
@Keinberger @mmagician
Update bin/faucet-client/src/main.rs
b5b483c 
Co-authored-by: Marti <[email protected]>
@Keinberger @mmagician
Update docs/src/getting-started/installation.md
2c1c2bd 
Co-authored-by: Marti <[email protected]>
@Keinberger
Merge pull request #196 from 0xMiden/kbg/feat/mint-command
d65d61d 
feat: implement mint command and rename binaries
@Keinberger Keinberger force-pushed the kbg/merge-main-to-next branch from f38ad92 to 1fd0f66 Compare January 19, 2026 17:00
@Keinberger Keinberger requested a review from igamigo January 19, 2026 17:01
@Keinberger Keinberger marked this pull request as ready for review January 19, 2026 17:01
@igamigo igamigo changed the base branch from next to main January 19, 2026 17:47
@igamigo igamigo changed the base branch from main to next January 19, 2026 17:47
igamigo
igamigo approved these changes Jan 19, 2026
View reviewed changes
Copy link
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for opening this PR. I checked that there are no conflicts against main and it looks good.
Two things though:

  • The CI is not passing, so we need to review that first
  • We should be careful to merge this without squash and merge, so that commits get added one by one

bin/faucet-client/src/lib.rs
@@ -0,0 +1 @@
pub mod mint;
Copy link
Collaborator

@igamigo igamigo Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Nothing to do for this PR, but now that I see this, we could have just probably avoided this level of indirection and just put the mint code here

@Keinberger
Copy link
Collaborator Author

Keinberger commented Jan 21, 2026

LGTM! Thanks for opening this PR. I checked that there are no conflicts against main and it looks good. Two things though:

  • The CI is not passing, so we need to review that first
  • We should be careful to merge this without squash and merge, so that commits get added one by one

From what I can see, it seems like the lint & test workflow are both failing because of miden-client imports. I guess this is because the miden-client is not yet functional as a crate, is that correct?

And thanks for pointing out how we should merge this PR.

@igamigo
Copy link
Collaborator

igamigo commented Jan 21, 2026

LGTM! Thanks for opening this PR. I checked that there are no conflicts against main and it looks good. Two things though:

  • The CI is not passing, so we need to review that first
  • We should be careful to merge this without squash and merge, so that commits get added one by one

From what I can see, it seems like the lint & test workflow are both failing because of miden-client imports. I guess this is because the miden-client is not yet functional as a crate, is that correct?

It seems this PR updated the client version, but we don't want to do that yet. The version you updated it to is not functional, so we should revert the Cargo.lock changes.

@Keinberger Keinberger force-pushed the kbg/merge-main-to-next branch from 1fd0f66 to 114bd40 Compare January 22, 2026 10:49
@Keinberger
Copy link
Collaborator Author

Keinberger commented Jan 22, 2026

LGTM! Thanks for opening this PR. I checked that there are no conflicts against main and it looks good. Two things though:

  • The CI is not passing, so we need to review that first
  • We should be careful to merge this without squash and merge, so that commits get added one by one

From what I can see, it seems like the lint & test workflow are both failing because of miden-client imports. I guess this is because the miden-client is not yet functional as a crate, is that correct?

It seems this PR updated the client version, but we don't want to do that yet. The version you updated it to is not functional, so we should revert the Cargo.lock changes.

You are right. Things should be working now!

@igamigo igamigo changed the base branch from next to main January 23, 2026 20:28
@igamigo igamigo changed the base branch from main to next January 23, 2026 20:29
@igamigo igamigo merged commit 2c3949c into next Jan 23, 2026
14 checks passed
@igamigo igamigo deleted the kbg/merge-main-to-next branch January 23, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igamigo igamigo igamigo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Keinberger @igamigo