chore: merge main into next #211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: rename existing miden-faucet binary to miden-faucet-client docs: update docs to include information about new miden-faucet-operator binary chore: move tests of miden-faucet-operator binary into dedicated folder docs(README): update README for binary separation chore: update changelog
docs: update instructions to include correct client start command and mint command usage
…client (reverse naming)
fix(Makefile): install faucet instructions target correct binary docs(README): added explainer for binary split chore: removed redundant readme key in bin/faucet-client/Cargo.toml chore: amend description satement in bin/faucet-operator/Cargo.toml
docs: Clarify mint command technical accuracy
…ries feat: implement backwards compatibility for legacy "miden-faucet" CLI command
chore: amend character size of separators docs(client/README): amend mint command explanation to be more technically accurate chore(CHANGELOG): mark binary separation as breaking
Co-authored-by: Marti <[email protected]>
Co-authored-by: Marti <[email protected]>
Co-authored-by: Marti <[email protected]>
feat: implement mint command and rename binaries
Brings mint command feature (#196) from main to next. Key changes: - Added new miden-faucet-client binary with mint command - Updated all documentation to use next's parameter conventions (api-bind-port, frontend-bind-port, no-frontend) - Moved mint feature to v0.13.0 in CHANGELOG (not patch release) - Regenerated Cargo.lock for next's dependencies Resolved conflicts: - Cargo.lock: Regenerated from scratch - docs/src/getting-started/quick-start.md: Used next's simplified parameters Note: Build requires miden-client compatibility fixes (separate work)
Keinberger
force-pushed
the
kbg/merge-main-to-next
branch
from
04bdce3 to
f38ad92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the changes from the latest PR #196 into
next.This PR also changes the
CHANGELOG.mdto include the changes of #196 in v13 instead of a patch release on v12.