fix: use correct hex capacity for word and digest hex encoding #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@igamigo Sorry for delay, reopened PR |
igamigo
reviewed
Jan 17, 2026
| self.w2, | ||
| self.w3 | ||
| ) | ||
| .unwrap(); |
Collaborator
There was a problem hiding this comment.
Please add a safety comment explaining why this is OK to unwrap
Author
There was a problem hiding this comment.
Please add a safety comment explaining why this is OK to unwrap
added comments
package-lock.json
Outdated
Author
There was a problem hiding this comment.
Why was this committed?
It's a good question and I don't know hpw it could appear, i didn't add this manually, but maybe there were issues with my branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen #1631
Adjust hex encoding buffers to allocate enough capacity for the full 64-character hexadecimal representation of a Word. Previously we used 32/Word::SERIALIZED_SIZE (bytes) as the Vec capacity, which was half of the required number of characters and caused unnecessary reallocations; now both word.rs and digest.rs use Word::SERIALIZED_SIZE * 2 for consistent and efficient hex formatting.