fix: correctly set track_latest on MMR
#1633
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 fixes:
track_latestonly based on whether there were client notes included in the block. This was not sufficient astrack_latestis only meaningful if the leaf forms a single-leaf tree; in other situations the MMR code expects that the leaf will already be merged otherwiseIt also adds a couple make commands to run tests with
test-dev(introduced in #1400) to run tests with debug assertionsWe should probably look into adding this to
mainas well