Skip to content

Conversation

@igamigo
Copy link
Collaborator

@igamigo igamigo commented Dec 28, 2025

This PR introduces 2 fixes:

  • (Closes debug assertions fail on integration tests #1402) When reconstructing the partial MMR, we were setting track_latest only based on whether there were client notes included in the block. This was not sufficient as track_latest is only meaningful if the leaf forms a single-leaf tree; in other situations the MMR code expects that the leaf will already be merged otherwise
  • Fixes the code that adjusts the authentication path for a smaller forest. The main thing there was that we were keeping "in-bounds" nodes (from the same subtree) that were still part of the largest forest's path, not the current smaller one. Also introduces some regression tests for this

It also adds a couple make commands to run tests with test-dev (introduced in #1400) to run tests with debug assertions

We should probably look into adding this to main as well

@igamigo igamigo force-pushed the igamigo-fix-debug-assertion branch from 76258ae to 95b7ab5 Compare December 29, 2025 00:18
@igamigo igamigo marked this pull request as ready for review December 29, 2025 00:19
@igamigo igamigo force-pushed the igamigo-fix-debug-assertion branch from 5e6cd95 to 329ea51 Compare December 29, 2025 02:28
@igamigo igamigo force-pushed the igamigo-fix-debug-assertion branch from 329ea51 to 077be9f Compare December 29, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

debug assertions fail on integration tests

2 participants