Enable getAccountDetails on web sdk RpcClient
#1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnullifier
changed the title
getAccountDetails on web sdk RpcClient
SantiagoPittella
approved these changes
Dec 23, 2025
Collaborator
SantiagoPittella
left a comment
SantiagoPittella
left a comment
There was a problem hiding this comment.
Nice PR, thanks!
igamigo
requested changes
Dec 26, 2025
Collaborator
igamigo
left a comment
igamigo
left a comment
There was a problem hiding this comment.
Code looks good to me, but left some comments on things I think we should address before merging. Mostly adding a few getters to the new struct, and adding docs.
Also, something to keep in mind is that the node's get_account_details will soon be deprecated, and will be replaced with a different flow that involves different RPC calls. For the most part it should not affect this, but we should also expose functions that do not necessarily return the whole account for users that just want to read an account's header.
0xnullifier
force-pushed
the
feat/web-sdk-rpc-fetch-account
branch
2 times, most recently
from
b5f022f to
ce25172
Compare
0xnullifier
force-pushed
the
feat/web-sdk-rpc-fetch-account
branch
from
ce25172 to
a154092
Compare
igamigo
reviewed
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a way to fetch accounts through the web rpc client without needing to add the account to the client itself by using
client.importAccountByIdUseful when you want to fetch faucet account to get the symbols and decimals. This also solves this Feedback issue.