Skip to content

feat: handle application-level errors from gRPC responses #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
swarna1101 wants to merge 4 commits into
base: next
Choose a base branch
from
Open

feat: handle application-level errors from gRPC responses #1564

swarna1101 wants to merge 4 commits into from

Conversation

@swarna1101
Copy link
Contributor

@swarna1101 swarna1101 commented Nov 28, 2025 •
edited
Loading

  • Add AppLevelError struct to represent application-level errors with code and message
  • Add RpcError::AppLevelError variant to distinguish from transport-level errors
  • Implement extraction of application-level errors from tonic::Status
    • Error code (u8) is encoded in Status details as a single byte
    • Error message is in Status message string
  • Update from_grpc_error to check for application-level errors before falling back to generic gRPC errors
  • Add helper function from_app_level_error for creating application-level errors

@igamigo can you pls check this

SantiagoPittella
SantiagoPittella reviewed Nov 28, 2025
View reviewed changes
juan518munoz
juan518munoz reviewed Dec 3, 2025
View reviewed changes
juan518munoz
juan518munoz reviewed Dec 3, 2025
View reviewed changes
juan518munoz
juan518munoz reviewed Dec 3, 2025
View reviewed changes
@juan518munoz
Copy link
Collaborator

juan518munoz commented Dec 3, 2025

Looks good!

Please update the changelog and then tag me for re-review.

@swarna1101
Copy link
Contributor Author

swarna1101 commented Dec 4, 2025

Looks good!

Please update the changelog and then tag me for re-review.

@juan518munoz can you pls review again , thanks

@swarna1101 swarna1101 force-pushed the feature/grpc-app-level-errors branch from 35ecf15 to 0ba5415 Compare December 6, 2025 07:32
juan518munoz
juan518munoz reviewed Dec 11, 2025
View reviewed changes
CHANGELOG.md Outdated

## 0.12.4 (TBD)

* Fixed a bug where insertions in the `Addresses` table in the IndexedDB Store resulted in the `id` and `address` fields being inverted with each other ([#1532](https://github.com/0xMiden/miden-client/pull/1532)).
Copy link
Collaborator

@juan518munoz juan518munoz Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this go under 0.13.0?

Copy link
Contributor Author

@swarna1101 swarna1101 Dec 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, pls do review @juan518munoz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SantiagoPittella SantiagoPittella Awaiting requested review from SantiagoPittella

@igamigo igamigo Awaiting requested review from igamigo

@juan518munoz juan518munoz Awaiting requested review from juan518munoz

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swarna1101 @juan518munoz @SantiagoPittella