feat: Optional limit on note-transport fetch #1516
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@mmagician @v0-e is the plan still to continue working on this feature/branch? |
Contributor
|
Yes I think so. We should first finalize the support for this serverside and then can probably revive this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A client may have too many notes to fetch from the transport layer. This adds an optional limit to the downloaded notes per each fetch request. Requires sync with 0xMiden/miden-note-transport#56.
Unsure how best to incorporate with the new
limit: Option<u32>argument in the client interface. Could be as a new argument inClient::fetch_private_notes. Currently it is not used (no limit is applied) on transport layer fetch request.