feat: Add RPC-enabled DataStore for lazy loading #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor note_screener initialization to use with_rpc method.
mmagician
reviewed
Dec 18, 2025
Contributor
mmagician
left a comment
mmagician
left a comment
There was a problem hiding this comment.
Could you also make sure to run lint jobs to clear the CI jobs?
| Ok(note_script) | ||
| }, | ||
| Err(rpc_err) => Err(DataStoreError::other(format!( | ||
| "Note script with root {script_root} not found locally or via RPC: {rpc_err}", |
Contributor
There was a problem hiding this comment.
this error message should not say "locally" since it's within the rpc-call match statement
Comment on lines
280
to
287
| if let Err(err) = store | ||
| .upsert_note_scripts(core::slice::from_ref(¬e_script)) | ||
| .await | ||
| { | ||
| // Log but don't fail - we still have the script to return | ||
| // In a no_std environment, we can't easily log, so we just continue | ||
| let _ = err; | ||
| } |
Contributor
There was a problem hiding this comment.
it would be good to understand the situation(s) when a script cannot be upserted and handle those error cases. It's a bit weird if we are able to fetch the script but not upsert it.
Also, at this point upsert shouldn't be necessary (we know it's not in the store, right?), is a pure insert available?
Refactor error handling and logging for fetching note scripts.
Reformatted import statements for better readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds RPC support to DataStore for lazy loading of note scripts and foreign account inputs when not found locally.
Resolves #1456