use a partial SMT to represent storage entries in accounts query #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
force-pushed
the
bernhard-617-batch-proof
branch
from
69a1424 to
5c849d3
Compare
drahnr
force-pushed
the
bernhard-617-batch-proof
branch
from
b6850b8 to
b64093a
Compare
drahnr
added
the
no docs
igamigo
reviewed
Aug 18, 2025
Author
|
@igamigo this is currently out of sync with the |
Author
|
I reverted some changes in 0xMiden/miden-node#1158 ( see 0xMiden/miden-node#1158 (comment) ), so this is good to once the former landed. |
Co-authored-by: igamigo <[email protected]>
tomyrd
approved these changes
Aug 22, 2025
Comment on lines
+227
to
+233
| partial_storage_smts.iter().try_for_each(|(_slot, partial_smt)| { | ||
| for (key, _value) in partial_smt.entries() { | ||
| // validate all required inner nodes of the merkle path for the specific leaf exist | ||
| let _proof = partial_smt.open(key)?; | ||
| } | ||
| } | ||
| Ok::<_, crate::rpc::RpcError>(()) | ||
| })?; |
Contributor
There was a problem hiding this comment.
Is this needed? Checking the internal logic of PartialSmt and Smt, PartialSmt::entries will return an iterator over the tracked leaves and PartialSmt::open will only fail if the leaf isn't tracked.
Collaborator
|
@drahnr, I think we could close this for now, no? |
Contributor
|
Yes, I think this is obsolete now. We may still come back to the general idea of this, but it'll probably look very different from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 0xMiden/miden-node#617
Requires 0xMiden/miden-node#1158