feat(AggLayer): UPDATE_GER note
#2333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
We should also add a safety check similar to #2173 to ensure that only the bridge account can consume this note. I added a comment to the mentioned issue so that tackling it could address both |
partylikeits1983
approved these changes
Jan 23, 2026
Contributor
partylikeits1983
left a comment
partylikeits1983
left a comment
There was a problem hiding this comment.
Looks good!
For now we just store the 256 bit GER in 2 slots, but not in an array just yet? Assuming will update this once the double word array PR lands: #2299
partylikeits1983
added
the
no changelog
Collaborator
Author
Exactly - but since we didn't store the GER at all until now, this should allow some minimal degree of testing against a real GER |
mmagician
added a commit
that referenced
this pull request
Jan 24, 2026
* feat: UPDATE_GER note outline * feat: working update ger note * chore: swap upper, lower GER parts * lint: regen error file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE_GERnote script that carries two storage words[GER_LOWER[4], GER_UPPER[4]]update_gerprocedure on the bridgecreate_bridge*helper functionscreate_bridge_account_buildernow uses bothBridgeIn&BridgeOutcomponents in a single accountBridgeOutdoesn't need themiden::agglayer::bridgestorage slot it used to haveBridgeIngets two storage slots to store single values (upper & lower limbs of the GER)closes #2159
closes #2137