-
Notifications
You must be signed in to change notification settings - Fork 106
feat(AggLayer): Solidity compatibility tests for MMR frontier code #2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mmagician
wants to merge
10
commits into
andrew-keccak-based-mmr-frontier
Choose a base branch
from
mmagician-solidity-compat
base: andrew-keccak-based-mmr-frontier
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(AggLayer): Solidity compatibility tests for MMR frontier code #2312
mmagician
wants to merge
10
commits into
andrew-keccak-based-mmr-frontier
from
mmagician-solidity-compat
+356
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into leaf<>root<>count paris; and canonical zeros
mmagician
commented
Jan 19, 2026
| miden-protocol = { features = ["std"], workspace = true } | ||
| primitive-types = { workspace = true } | ||
| rstest = { workspace = true } | ||
| serde = { features = ["derive"], version = "1.0" } |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: to be changed once #2313 lands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here, we're getting to a stage with the AggLayer integration where we should check for compatibility with the Solidity implementation.
This PR adds a small foundry project inside the
miden-agglayercrate:forgecommands to generate the test vectors. The vectors are generated by calling the Solidity functions of interest_addLeaf&getRootmake generate-solidity-test-vectorscommand to locally re-generate the test filesKeccakMmrFrontier32(currently we're not comparing with the output of MASM, since we independently already have Rust<>MASM compatibility test, so by extension we have Solidity<>MASM compat)To be done in a follow-up PR:
miden-testing/agglayercode intomiden-agglayercrate. Otherwise, the Rust compat test (located inmiden-testingdepends on the test vectors which are generated in a different crate (miden-agglayer)