chore: rename NoteAttachmentType and NoteAttachmentContentType
#2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippGackstatter
changed the title
NoteAttachmentType and NoteAttachmentContentTypeNoteAttachmentType and NoteAttachmentContentType
bobbinth
approved these changes
Jan 14, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of comments inline, the main one about reversing padding for the note attachment array commitment.
PhilippGackstatter
force-pushed
the
pgackst-remove-aux-and-exec-hint
branch
from
aa0554f to
60fa121
Compare
This reverts commit cfe9702.
PhilippGackstatter
force-pushed
the
pgackst-note-attachment-cleanup
branch
from
3869233 to
b77f611
Compare
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Jan 15, 2026
…xMiden#2268) * feat: Pad elements in `NoteAttachmentArray` before committing * chore: Rename `NoteAttachmentType` -> `NoteAttachmentScheme` * chore: rename "attachment type info" to "attachment kind scheme" * chore: Rename `NoteAttachmentContentType` -> `NoteAttachmentKind` * chore: rename attachment scheme untyped to unknown * chore: Swap kind and scheme in procedure signatures * chore: add changelog * Revert "feat: Pad elements in `NoteAttachmentArray` before committing" This reverts commit cfe9702. * chore: rename `NoteAttachmentScheme::unknown` to `none` * fix: more content type -> attachment kind renames
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Jan 15, 2026
…xMiden#2268) * feat: Pad elements in `NoteAttachmentArray` before committing * chore: Rename `NoteAttachmentType` -> `NoteAttachmentScheme` * chore: rename "attachment type info" to "attachment kind scheme" * chore: Rename `NoteAttachmentContentType` -> `NoteAttachmentKind` * chore: rename attachment scheme untyped to unknown * chore: Swap kind and scheme in procedure signatures * chore: add changelog * Revert "feat: Pad elements in `NoteAttachmentArray` before committing" This reverts commit cfe9702. * chore: rename `NoteAttachmentScheme::unknown` to `none` * fix: more content type -> attachment kind renames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the commitment ofNoteAttachmentArrayto be built over the elements padded to the next multiple of 8 (double word size). This is equivalent to howNoteInputsare built. This should make it possible to use the efficientpipe_double_words_preimage_to_memorywhen working on Computeattachment_sizeduringoutput_note::set_attachment#2266. This is done now so that working on that issue may be a non-breaking or less breaking change.NoteAttachment#2249 (comment))NoteAttachmentType->NoteAttachmentSchemeNoteAttachmentType::untyped->NoteAttachmentScheme::noneNoteAttachmentContentType->NoteAttachmentKindset_attachmentand related APIs fromkind, scheme, ATTACHMENTtoscheme, kind, ATTACHMENTso that kind and ATTACHMENT are grouped together. This makes more sense since kind identifies the structure or ATTACHMENT and scheme is a separate value. If you disagree with this change, its a single commit that can be easily reverted.Note: One more PR is needed to document attachments in the docs.
closes #2109