feat: introduce standard NetworkAccountTarget attachment
#2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergerad
reviewed
Jan 13, 2026
sergerad
approved these changes
Jan 13, 2026
bobbinth
approved these changes
Jan 13, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left just a couple of small comments inline.
PhilippGackstatter
force-pushed
the
pgackst-note-attachment-kernel-api
branch
from
cff70aa to
e22c488
Compare
PhilippGackstatter
force-pushed
the
pgackst-network-note-attachment
branch
from
7726b77 to
e8d4f86
Compare
This was referenced Jan 15, 2026
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Jan 15, 2026
) * feat: Implement `NetworkAccountTarget` * chore: Let SPAWN note create output notes with attachment * chore: test creating note with NetworkAccountTarget attachment * chore: add changelog * fix: don't use super::* import * feat: Add `WellKnownNoteAttachment` * chore: Use 8-bit tag for exec hint; remove `AfterBlockNumber` * chore: improve network account target error
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Jan 15, 2026
) * feat: Implement `NetworkAccountTarget` * chore: Let SPAWN note create output notes with attachment * chore: test creating note with NetworkAccountTarget attachment * chore: add changelog * fix: don't use super::* import * feat: Add `WellKnownNoteAttachment` * chore: Use 8-bit tag for exec hint; remove `AfterBlockNumber` * chore: improve network account target error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a standard
NetworkAccountTargetattachment for use in network transactions. It replacesNoteTag::NetworkAccount(removed in #2219) to identify notes targeted at network accounts. To create a "targeted network note", i.e. a note intended to be consumed by a network account, this attachment should be used instead of usingNoteTag::NetworkAccount.Miden node can try decoding a
NoteAttachment(accessible inNoteMetadata) into aNetworkAccountTargetto check if a note is targeted at a network account. An alternative way would be to check ifNoteAttachment::attachment_type() == NetworkAccountTarget::ATTACHMENT_TYPEand only then attempt decoding.Tagging @Mirko-von-Leipzig and @sergerad for review since this type will be used in network transactions. Please let me know if the process I described would work or if you need any additional APIs exposed, etc.
part of #2109