feat(testing): improve error message quality in miden-testing

[avorylli]

Introduce ExecError newtype wrapper around ExecutionError that uses PrintDiagnostic for better error formatting.

Changes:

• Add ExecError wrapper with improved diagnostics
• Update TransactionContext::execute_code to return ExecError
• Replace all miette::Result with anyhow::Result in tests
• Remove all .into_diagnostic() calls
• Update assert_execution_error! macro to handle ExecError

Closes #2040

[avorylli]

Also I have a question. Firstly, before pushing a pr I run these commands:

1. make check
2. make test
3. make clippy
4. make lint

As I understood these are the necessary command to pass all the CI here in miden base,

So the question is are these all the commands needed to be ran or is there anything else?

[avorylli]

Sorry, closed it accidentally

[PhilippGackstatter]

So the question is are these all the commands needed to be ran or is there anything else?

I think make lint and make doc should cover most of the CI checks.

[PhilippGackstatter]

Looks great! I left two small comments after which we can merge.

Could you also merge in latest next and run make build-no-std to rebuild the generated files and commit them? Thanks!

[PhilippGackstatter]

Unfortunately, the merge conflicts weren't resolved correctly and CI isn't passing now. Please check locally with make test and make lint that everything is working before requesting a review, thank you!

[bobbinth]

Seems like the CI is still not passing. @avorylli - is this something you can fix?

[PhilippGackstatter]

Looks good to me!

I reverted to the commit I last reviewed which was already 99% there, merged next and made small adjustments.