chore: move MSRV check from PR CI to release workflows #2233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
added
the
no changelog
Contributor
|
The changes to move the job to release time look ok, but let's address the current issues msrv tool is facing before merging: Could you look into that please? |
Contributor
Author
|
@mmagician The current issues are very probably the runner running out of space, as you can probably check by running the script ( |
Contributor
Author
|
Closing to make sure this does not endanger release workflow. |
Contributor
Author
|
Re-opening in light of #2234. |
huitseeker
force-pushed
the
huitseeker/ci-msrv-to-release
branch
2 times, most recently
from
5109735 to
990278b
Compare
partylikeits1983
approved these changes
Jan 12, 2026
huitseeker
added a commit
to 0xMiden/miden-node
that referenced
this pull request
Jan 13, 2026
The MSRV check now only runs on push to main/next (in publish-dry-run.yml) and when publishing a release (in publish-main.yml), rather than on every PR. This makes PR CI faster and less resource-intensive. Any MSRV issues will still be caught before publication, and can be fixed locally using scripts/check-msrv.sh. Changes: - Delete .github/workflows/msrv.yml - Add cleanup-runner action for freeing disk space - Add MSRV check steps to publish-dry-run.yml - Add MSRV check steps to publish-main.yml See also: - 0xMiden/miden-base#2233 - 0xMiden/miden-vm#2468 - 0xMiden/miden-vm#2460
Contributor
|
@huitseeker could you see about the following merge requirement we have on miden-base (I actually thought this was org specific?): "Commits must have verified signatures." |
Mirko-von-Leipzig
pushed a commit
to 0xMiden/miden-node
that referenced
this pull request
Jan 13, 2026
The MSRV check now only runs on push to main/next (in publish-dry-run.yml) and when publishing a release (in publish-main.yml), rather than on every PR. This makes PR CI faster and less resource-intensive. Any MSRV issues will still be caught before publication, and can be fixed locally using scripts/check-msrv.sh. Changes: - Delete .github/workflows/msrv.yml - Add cleanup-runner action for freeing disk space - Add MSRV check steps to publish-dry-run.yml - Add MSRV check steps to publish-main.yml See also: - 0xMiden/miden-base#2233 - 0xMiden/miden-vm#2468 - 0xMiden/miden-vm#2460
Previously, the Minimum Supported Rust Version (MSRV) check ran on every pull request and push to next. This was expensive because cargo-msrv downloads additional Rust toolchains to verify compatibility. Now the MSRV check only runs: - On push to main/next (in release-plz-dry-run.yml) - When publishing a release (in release-plz.yml) This makes PR CI faster and uses less memory. Any MSRV issues will still be caught before publication, and can be fixed locally using the scripts/check-msrv.sh script. Changes: - Delete .github/workflows/msrv.yml - Add MSRV check steps to release-plz-dry-run.yml - Add MSRV check steps to release-plz.yml
huitseeker
force-pushed
the
huitseeker/ci-msrv-to-release
branch
from
990278b to
2458576
Compare
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Jan 15, 2026
Previously, the Minimum Supported Rust Version (MSRV) check ran on every pull request and push to next. This was expensive because cargo-msrv downloads additional Rust toolchains to verify compatibility. Now the MSRV check only runs: - On push to main/next (in release-plz-dry-run.yml) - When publishing a release (in release-plz.yml) This makes PR CI faster and uses less memory. Any MSRV issues will still be caught before publication, and can be fixed locally using the scripts/check-msrv.sh script. Changes: - Delete .github/workflows/msrv.yml - Add MSRV check steps to release-plz-dry-run.yml - Add MSRV check steps to release-plz.yml
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Jan 15, 2026
Previously, the Minimum Supported Rust Version (MSRV) check ran on every pull request and push to next. This was expensive because cargo-msrv downloads additional Rust toolchains to verify compatibility. Now the MSRV check only runs: - On push to main/next (in release-plz-dry-run.yml) - When publishing a release (in release-plz.yml) This makes PR CI faster and uses less memory. Any MSRV issues will still be caught before publication, and can be fixed locally using the scripts/check-msrv.sh script. Changes: - Delete .github/workflows/msrv.yml - Add MSRV check steps to release-plz-dry-run.yml - Add MSRV check steps to release-plz.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the MSRV check ran on every pull request and push to next. This was expensive (in CI runner disk space, and cache) because
cargo-msrvdownloads additional Rust toolchains to verify compatibility.Now the MSRV check only runs:
This makes PR CI faster and less memory-dependent. Any MSRV issues will still be caught before publication, and can be fixed locally using the scripts/check-msrv.sh script.
Changes: