Skip to content

chore: remove library check for MAX_INPUTS_PER_NOTE #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmagician wants to merge 2 commits into from
Closed

chore: remove library check for MAX_INPUTS_PER_NOTE #2231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1b09d3
chore: remove the library check for num inputs
mmagician Jan 6, 2026
49c285b
chore: remove redundant (now unused) constant
mmagician Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions crates/miden-protocol/asm/protocol/note.masm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ const ERR_PROLOGUE_NOTE_INPUTS_LEN_EXCEEDED_LIMIT="number of note inputs exceede
#!
#! Invocation: exec
pub proc compute_inputs_commitment
# check that number of inputs is less than or equal to MAX_INPUTS_PER_NOTE
dup.1 push.MAX_INPUTS_PER_NOTE u32assert2.err=ERR_PROLOGUE_NOTE_INPUTS_LEN_EXCEEDED_LIMIT
u32lte assert.err=ERR_PROLOGUE_NOTE_INPUTS_LEN_EXCEEDED_LIMIT
Comment on lines -36 to -38
Copy link
Contributor

@bobbinth bobbinth Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still keep this check - the use case for this is different from what we do in the prologue. Specifically, this procedure is used to build note inputs for output notes. So, we still want to make sure here that the user doesn't compute invalid note input commitment.

# => [inputs_ptr, num_inputs]

# compute the inputs commitment
Expand All @@ -47,9 +44,6 @@ pub proc compute_inputs_commitment
# => [INPUTS_COMMITMENT]
end

# Re-export the max inputs per note constant.
pub use ::miden::protocol::util::note::MAX_INPUTS_PER_NOTE
Comment on lines -50 to -51
Copy link
Contributor

@bobbinth bobbinth Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to the top of the file - maybe after the "errors" section (create a new "constants" section).

Also, not related to this PR, but we should update the docs. Specifically, here we no longer have get_max_inputs_per_note procedure. Instead, we are exporting this constant.


#! Writes the assets data stored in the advice map to the memory specified by the provided
#! destination pointer.
#!
Expand Down
5 changes: 0 additions & 5 deletions crates/miden-protocol/asm/shared_utils/util/note.masm
View file
Open in desktop

This file was deleted.

Loading