feat: instead of procs, import constants directly #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase to import constants directly instead of accessing them through procedure calls, improving code clarity and reducing indirection. The changes primarily affect assembly files in the miden-protocol crate.
- Converts private constants to public constants with direct access
- Removes wrapper procedures that returned constant values
- Updates all call sites to use
push.CONSTANT_NAMEinstead ofexec.constants::get_constant_name()
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/miden-protocol/asm/kernels/transaction/lib/constants.masm | Converted constants from private to public, removed all wrapper procedures, added EMPTY_SMT_ROOT as a constant array |
| crates/miden-protocol/asm/kernels/transaction/lib/prologue.masm | Updated imports to directly import specific constants, replaced procedure calls with direct constant access |
| crates/miden-protocol/asm/kernels/transaction/lib/output_note.masm | Updated imports and replaced procedure call with direct constant access |
| crates/miden-protocol/asm/kernels/transaction/lib/note.masm | Updated imports and replaced procedure call with direct constant access |
| crates/miden-protocol/asm/kernels/transaction/lib/memory.masm | Updated imports, replaced procedure calls with direct constant access, removed duplicate ACCOUNT_PROCEDURE_DATA_LENGTH definition |
| crates/miden-protocol/asm/kernels/transaction/lib/epilogue.masm | Updated imports and replaced procedure calls with direct constant access |
| crates/miden-protocol/asm/kernels/transaction/lib/account_delta.masm | Updated imports and replaced procedure call with direct constant access |
| crates/miden-protocol/asm/kernels/transaction/lib/account.masm | Updated imports, replaced procedure calls with direct constant access, removed duplicate ACCOUNT_PROCEDURE_DATA_LENGTH definition |
| crates/miden-protocol/asm/protocol/note.masm | Replaced hardcoded value with constant reference, changed re-export from procedure to constant |
| crates/miden-protocol/asm/shared_utils/util/note.masm | Converted constant to public and removed wrapper procedure |
| crates/miden-testing/src/kernel_tests/tx/test_output_note.rs | Updated test to import and use constant directly instead of calling procedure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mmagician
approved these changes
Jan 5, 2026
| #! - max_inputs_per_note is the max inputs per note. | ||
| pub use ::miden::protocol::util::note::get_max_inputs_per_note | ||
| # Re-export the max inputs per note constant. | ||
| pub use ::miden::protocol::util::note::MAX_INPUTS_PER_NOTE |
Collaborator
There was a problem hiding this comment.
nit: do we still need to re-export this?
Contributor
There was a problem hiding this comment.
I don't have a strong opinion here - maybe @PhilippGackstatter can suggest?
If we do end up keeping it, I'd move this re-export to the top of the file.
mmagician
added
the
no changelog
bobbinth
approved these changes
Jan 6, 2026
| #! - max_inputs_per_note is the max inputs per note. | ||
| pub use ::miden::protocol::util::note::get_max_inputs_per_note | ||
| # Re-export the max inputs per note constant. | ||
| pub use ::miden::protocol::util::note::MAX_INPUTS_PER_NOTE |
Contributor
There was a problem hiding this comment.
I don't have a strong opinion here - maybe @PhilippGackstatter can suggest?
If we do end up keeping it, I'd move this re-export to the top of the file.
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Jan 15, 2026
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2168