refactor: split account module into submodules #2200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you! This will conflict with a couple of things currently in progress. Could you rebase this on top of #2197? |
DeVikingMark
force-pushed
the
refactor/account-submodules
branch
from
ac31446 to
eb3c574
Compare
DeVikingMark
force-pushed
the
refactor/account-submodules
branch
from
eb3c574 to
ee72c2d
Compare
Author
Hey boss! Is everything correct now? |
Contributor
|
The current changes seem to only add new code, whereas splitting would typically involve moving files (some code deleted, some added). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split the large
$kernel::accountmodule into submodules to improve code organization and maintainability. Closes #2146Changes
account/storage.masm- storage-related procedures (get_item, set_item, get_map_item, etc.)account/vault.masm- vault-related procedures (add_asset_to_vault, get_balance, etc.)account/code.masm- code-related procedures (authenticate_and_track_procedure, has_procedure, etc.)account/mod.masm- main module with commitments, validation, data loaders, and re-exportsaccount.masmfile