feat: Introduce Word wrapper for storage map keys #2124
Conversation
|
@PhilippGackstatter there are some more changes to be made but I wanted get your opinion on the general direction of this change before that. |
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
@varun-doshi Thank you for working on this! I took a first look and the general direction is the right one 👍
| #[derive(Debug, PartialEq, Eq, Clone, Copy, PartialOrd, Ord)] | ||
| pub struct StorageMapKey(Word); |
There was a problem hiding this comment.
We should soon have the ability to add #[derive(WordWrapper)] introduced in #2108, and once that is merged we should add it.
| use crate::Felt; | ||
|
|
||
| #[derive(Debug, PartialEq, Eq, Clone, Copy, PartialOrd, Ord)] | ||
| pub struct HashedStorageMapKey(Word); |
There was a problem hiding this comment.
Same here regarding adding WordWrapper.
| } | ||
|
|
||
| /// Returns the leaf index of a map key. | ||
| pub fn hashed_map_key_to_leaf_index(&self) -> Felt { |
There was a problem hiding this comment.
This could look just like AssetVault::to_leaf_index:
miden-base/crates/miden-objects/src/asset/vault/vault_key.rs
Lines 64 to 67 in 0cd80af
|
@varun-doshi is this still on your radar? |
3 participants
Fixes #1864