Skip to content

Tracking PR for Plonky3 v0.4.2 #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adr1anh wants to merge 5 commits into
base: next
Choose a base branch
from
Open

Tracking PR for Plonky3 v0.4.2 #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5635e61
refactor: replace p3-miden-goldilocks with upstream p3-goldilocks
adr1anh Jan 5, 2026
8e88d77
chore: update plonky3
adr1anh Jan 5, 2026
9ae98ef
chore: update p3-miden to latest commit
adr1anh Jan 5, 2026
317e600
chore: allow 0xMiden git sources in cargo-deny
adr1anh Jan 5, 2026
c20e9b6
refactor: revert LEAVES to const now that P3 0.4.2 has const construc…
huitseeker Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 67 additions & 70 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,7 @@ wildcards = "allow"
allow-registry = ["https://github.com/rust-lang/crates.io-index"]
unknown-git = "deny"
unknown-registry = "deny"

[sources.allow-org]
# Allow p3-miden crates from the 0xMiden organization (not yet published to crates.io)
github = ["0xMiden"]
Comment on lines +54 to +57
Copy link
Contributor Author

@adr1anh adr1anh Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[sources.allow-org]
# Allow p3-miden crates from the 0xMiden organization (not yet published to crates.io)
github = ["0xMiden"]

18 changes: 9 additions & 9 deletions miden-crypto/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,17 +118,17 @@ thiserror = { default-features = false, version = "2.0" }
x25519-dalek = { default-features = false, features = ["static_secrets"], version = "2.0" }

# Upstream Plonky3 dependencies
p3-air = { default-features = false, version = "0.4" }
p3-challenger = { default-features = false, version = "0.4" }
p3-field = { default-features = false, version = "0.4" }
p3-maybe-rayon = { default-features = false, version = "0.4" }
p3-symmetric = { default-features = false, version = "0.4" }
p3-util = { default-features = false, version = "0.4" }
p3-air = { default-features = false, version = "0.4.2" }
p3-challenger = { default-features = false, version = "0.4.2" }
p3-field = { default-features = false, version = "0.4.2" }
p3-goldilocks = { default-features = false, version = "0.4.2" }
p3-maybe-rayon = { default-features = false, version = "0.4.2" }
p3-symmetric = { default-features = false, version = "0.4.2" }
p3-util = { default-features = false, version = "0.4.2" }

# Miden-specific Plonky3 crates
p3-miden-air = { default-features = false, version = "0.4" }
p3-miden-goldilocks = { default-features = false, version = "0.4" }
p3-miden-prover = { default-features = false, version = "0.4" }
p3-miden-air = { branch = "tracking-0.4.2", default-features = false, git = "https://github.com/0xMiden/p3-miden" }
p3-miden-prover = { branch = "tracking-0.4.2", default-features = false, git = "https://github.com/0xMiden/p3-miden" }
Comment on lines +130 to +131
Copy link
Contributor Author

@adr1anh adr1anh Jan 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
p3-miden-air = { branch = "tracking-0.4.2", default-features = false, git = "https://github.com/0xMiden/p3-miden" }
p3-miden-prover = { branch = "tracking-0.4.2", default-features = false, git = "https://github.com/0xMiden/p3-miden" }
p3-miden-air = { default-features = false, version = "0.4.2" }
p3-miden-prover = { default-features = false, version = "0.4.2" }


[dev-dependencies]
assert_matches = { default-features = false, version = "1.5" }
Expand Down
2 changes: 1 addition & 1 deletion miden-crypto/src/hash/blake/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use core::{
};

use p3_field::{BasedVectorSpace, PrimeField64};
use p3_miden_goldilocks::Goldilocks as Felt;
use p3_goldilocks::Goldilocks as Felt;

use super::HasherExt;
use crate::utils::{
Expand Down
2 changes: 1 addition & 1 deletion miden-crypto/src/hash/blake/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
use alloc::vec::Vec;

use p3_field::PrimeField64;
use p3_miden_goldilocks::Goldilocks as Felt;
use p3_goldilocks::Goldilocks as Felt;
use proptest::prelude::*;

use super::*;
Expand Down
2 changes: 1 addition & 1 deletion miden-crypto/src/hash/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ pub mod sha2;

/// Poseidon2 hash function.
pub mod poseidon2 {
pub use p3_miden_goldilocks::Poseidon2Goldilocks;
pub use p3_goldilocks::Poseidon2Goldilocks;

pub use super::algebraic_sponge::poseidon2::{
Poseidon2, Poseidon2Challenger, Poseidon2Compression, Poseidon2Hasher,
Expand Down
Loading