Sketch out the forest interface #702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrecursion
added
no changelog
iamrecursion
changed the title
iamrecursion
force-pushed
the
forest-prefix-container
branch
from
0ec04b6 to
9be5a3c
Compare
iamrecursion
force-pushed
the
forest-interface
branch
from
0a50ee8 to
bc0a88a
Compare
iamrecursion
force-pushed
the
forest-prefix-container
branch
from
9be5a3c to
542b89c
Compare
iamrecursion
force-pushed
the
forest-interface
branch
from
bc0a88a to
684ea20
Compare
iamrecursion
force-pushed
the
forest-prefix-container
branch
2 times, most recently
from
4f7e0cc to
cf9f2d9
Compare
iamrecursion
force-pushed
the
forest-interface
branch
from
684ea20 to
739e3df
Compare
bobbinth
reviewed
Jan 5, 2026
bobbinth
reviewed
Jan 5, 2026
bobbinth
reviewed
Jan 5, 2026
bobbinth
reviewed
Jan 5, 2026
iamrecursion
force-pushed
the
forest-prefix-container
branch
from
cf9f2d9 to
4a38503
Compare
iamrecursion
force-pushed
the
forest-interface
branch
from
739e3df to
e9fc91a
Compare
iamrecursion
force-pushed
the
forest-prefix-container
branch
from
4a38503 to
b504714
Compare
iamrecursion
force-pushed
the
forest-interface
branch
2 times, most recently
from
3265ef5 to
e8924f8
Compare
iamrecursion
force-pushed
the
forest-prefix-container
branch
from
b504714 to
e68fe44
Compare
This commit contains a sketch of the interface and skeleton for the new forest implementation itself. It is primarily here to ensure that the rough interface is sane before implementation begins in earnest.
iamrecursion
force-pushed
the
forest-interface
branch
from
e8924f8 to
5c0f891
Compare
Collaborator
Author
|
Closing in favour of an upcoming PR with a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This contains a sketch of the interface and skeleton for the new forest implementation itself. It is primarily here to ensure that the rough interface is sane before implementation begins in earnest.
Much like for #700 and #701, a few places in the current code are marked as
#[allow(dead_code)]. This is to prevent warnings from failing the build while still allowing the private code to be merged incrementally.I also argue that, as this is internal code, it does not require a changelog entry. Please let me know if you disagree.
Checklist before requesting a review
nextaccording to naming convention.