chore: expand & re-use lint CI workflows #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
added
the
no changelog
mmagician
commented
Sep 1, 2025
| /// Returns an iterator over the [`InnerNode`] and the respective [`NodeIndex`] of the | ||
| /// [`PartialSmt`]. | ||
| pub fn inner_node_indicies(&self) -> impl Iterator<Item = (NodeIndex, InnerNode)> + '_ { | ||
| pub fn inner_node_indices(&self) -> impl Iterator<Item = (NodeIndex, InnerNode)> + '_ { |
Contributor
Author
There was a problem hiding this comment.
so this was added in #494 to support 0xMiden/miden-node#1158, but (for now?) the latter doesn't use these getters.
Contributor
There was a problem hiding this comment.
Yes, we still need to propagate the dependencies to miden base/node.
mmagician
changed the title
mmagician
changed the title
bobbinth
approved these changes
Sep 3, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left one small comment inline and also seems to have broken the build when trying to resolve merge conflicts (sorry!). Once these are addressed, we should be good to merge.
| /// Returns an iterator over the [`InnerNode`] and the respective [`NodeIndex`] of the | ||
| /// [`PartialSmt`]. | ||
| pub fn inner_node_indicies(&self) -> impl Iterator<Item = (NodeIndex, InnerNode)> + '_ { | ||
| pub fn inner_node_indices(&self) -> impl Iterator<Item = (NodeIndex, InnerNode)> + '_ { |
Contributor
There was a problem hiding this comment.
Yes, we still need to propagate the dependencies to miden base/node.
mmagician
force-pushed
the
mmagician-reuse-workflows
branch
from
0bdc589 to
7b29d71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
typos,toml,workspace-lintsandunused_depsjobsEDIT: I'm not 100% convinced about re-using the workflows. It makes the CI much less transparent (one needs to look outside of this repo to find out which jobs are actually run as part of linting).
Checklist before requesting a review
nextaccording to naming convention.