Skip to content

feat: rework test-harness for integration tests #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lima-limon-inc wants to merge 4 commits into
base: pr/migrate-to-v0.21.1
Choose a base branch
from
Open

feat: rework test-harness for integration tests #896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61281fd
chore: migrate to VM v0.22 and use published v0.14 protocol crates
greenhat Mar 25, 2026
cef94ea
feat: remove testing funcitons in favor of miden-protocol equivalents
lima-limon-inc Feb 25, 2026
d74a124
feat: add midenup init to CI
lima-limon-inc Mar 9, 2026
913537e
fix: restore compile_rust_package
lima-limon-inc Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,15 @@ jobs:
if ! cargo make --version 2>/dev/null; then
cargo install cargo-make --force
fi

# Some integration tests use midenup to compile the example projects
- name: Install midenup
run: |
if ! miden help 2>/dev/null; then
cargo install --git https://github.com/0xMiden/midenup
midenup init
fi
Comment on lines +322 to +327
Copy link
Contributor Author

@lima-limon-inc lima-limon-inc Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, accessing the miden interface requires further intervention by adding some variables to the system's $PATH. This is not ideal for cases like this I believe.

Copy link
Contributor Author

@lima-limon-inc lima-limon-inc Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create an issue on midenup to track this: 0xMiden/midenup#165

Copy link
Contributor

@greenhat greenhat Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need it anymore after we switched to using cargo-miden lib for package compilation.


- name: Test
run: |
cargo make test -E 'package(midenc-integration-network-tests)'
Expand Down
Loading
Loading