Track variable locations #820
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds sveral features/fixes for improved debugging:
1. Synthetic source locations: Compiler-generated code (like local
initialization, ABI transforms) now uses SourceSpan::SYNTHETIC instead
of UNKNOWN. This differentiates compiler-generated code from truly
unknown locations and renders as #loc(synthetic) in output.
2. -Z print-masm-source-locations: New flag to print source locations
as #loc("file":line:col) annotations in MASM output.
3. -Z remap-path-prefix=FROM=TO: Remap source path prefixes for resolving
paths from DWARF when sources are in different locations (e.g., stdlib).
4. Use current_span to have more real source locations attached --
currently we used Default locations a lot - for example, each
operator would start with it.
5. Fix wasm component-level DWARF parsing
Requires miden-vm with SourceSpan::SYNTHETIC debug type.
Represend variables values at HIR level. Run tests as: ``` $ lit tests/lit/debug ```
Introduce DebugVar decorators.
Prepare and emit Debug Info into masp. Add SectionId::DEBUG_INFO.
Tool to print .debug_info section. Run lit test: $ litcheck lit run --verbose tests/lit/debugdump In addition, add docs/DebugInfoFormat.md to describe the format itself.
Collaborator
Author
|
Goes on top of #812. |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track variable locations at HIR and MASM levels.
Add DebugVar decorator and new debug_info section in the final .masp.
Also, add
miden-debugdumptool to dump .debug_info section, so we can explore the custom section from the package.vm part: 0xMiden/miden-vm#2471